775703 - Share web app install code between Firefox and the webapp runtime

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Web Apps, defect, P3)

Description

[Ed Lee :Mardak]

Currently the runtime's web app install flow is separately implemented:
http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappsHandler.jsm#69

from the Firefox flow that was recently updated to allow appcache preloading (bug 760365) and notification (bug 755934):
http://mxr.mozilla.org/mozilla-central/source/browser/modules/webappsUI.jsm#107

It would be good to keep the two flows identical (other than the UI to prompt the user: firefox=doorhanger, runtime=prompt). So somehow we should refactor the code to give the runtime access to the firefox code.

Currently, the runtime is already importing Cu.import("resource://gre/modules/WebappsInstaller.jsm"); which resides at browser/modules/WebappsInstaller.jsm	

But if the runtime has access to that file, it should be able to access browser/modules/webappsUI.jsm just fine.

One tricky part in this refactoring is the access to strings. Firefox would use chrome://browser/locale while the runtime uses chrome://webapprt/locale

Either we let Firefox/runtime have access to the other's strings, put the strings somewhere common, or we duplicate them.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

It doesn't make a lot of sense to share UI code because the UI is different. For example, it's conceivable that the strings used in firefox and the runtime would be different, or that they display different kides of notification in the future (which will make us have to unshare the code later).

What could be done is to move the DOMApplicationRegistry.confirmInstall (+ the appcache part) to somewhere else, because that doesn't really pertain to UI.

Comment 2

[Marco Castelluccio [:marco]]

With bug 777402 we support appcache preloading through webapprt. Anyway it'd be good to share some code if possible.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Per bug 1238079, we're going to disable the desktop web runtime and remove it
from the codebase, so we won't fix these bugs in the integration between Firefox and the runtime.