Last Comment Bug 775803 - Move WebappsInstaller from browser/modules to toolkit/webapps
: Move WebappsInstaller from browser/modules to toolkit/webapps
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Web Apps (show other bugs)
: Trunk
: All All
: P2 normal
: Firefox 17
Assigned To: :Felipe Gomes (needinfo me!)
: Jason Smith [:jsmith]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-19 17:56 PDT by :Felipe Gomes (needinfo me!)
Modified: 2016-02-04 15:00 PST (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (2.08 KB, patch)
2012-07-19 17:58 PDT, :Felipe Gomes (needinfo me!)
mh+mozilla: review+
Details | Diff | Splinter Review

Description :Felipe Gomes (needinfo me!) 2012-07-19 17:56:05 PDT
The WebappsInstaller code is mostly browser code. However, it's used by both firefox and webapprt. With the imminent move of app resources in bug 755724, it's my understading that the webapprt won't be able to access anymore the files packaged in browser. Benjamin or Glandium, is that correct?

If so, we need to move it toolkit to keep app installation from inside webapprt working. Moving it there has other advantages as well, for example Wesj wanted access to some of the functions in WebappsIconHelper that this patch moves as well.
Comment 1 :Felipe Gomes (needinfo me!) 2012-07-19 17:58:43 PDT
Created attachment 644106 [details] [diff] [review]
Patch
Comment 2 :Felipe Gomes (needinfo me!) 2012-08-02 17:23:00 PDT
Comment on attachment 644106 [details] [diff] [review]
Patch

See comment 0
Comment 3 :Felipe Gomes (needinfo me!) 2012-08-03 20:43:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/01f85b0fe9fc
Comment 4 Ed Morley [:emorley] 2012-08-04 11:17:34 PDT
https://hg.mozilla.org/mozilla-central/rev/01f85b0fe9fc

Note You need to log in before you can comment on or make changes to this bug.