Closed
Bug 776135
Opened 12 years ago
Closed 12 years ago
Social toolbar styling on Windows
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: todd, Assigned: jaws)
Details
(Whiteboard: [Fx16])
Attachments
(3 files, 5 obsolete files)
7.12 KB,
image/jpeg
|
Details | |
4.93 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
4.85 KB,
patch
|
Details | Diff | Splinter Review |
The Social API toolbar is not displaying properly on Windows. Attachment says it all.
Comment 1•12 years ago
|
||
fixes css for provider button icon
Assignee: nobody → mixedpuppy
Attachment #644531 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Whiteboard: [Fx16]
Updated•12 years ago
|
Attachment #644531 -
Flags: review?(gavin.sharp) → review?(jaws)
Comment 2•12 years ago
|
||
Comment on attachment 644531 [details] [diff] [review] css patch >+#social-provider-image .button-icon { >+ max-height: 16px; >+ max-width: 16px; >+} >+#social-provider-image .button-box { >+ padding: 0; >+ margin: 0; >+ background: transparent; >+ border: none; >+} >+#social-provider-image .button-menu-dropmarker { >+ display: none; >+} Use the child selector. >+#social-provider-image:-moz-focusring > .button-box { >+ border: none; >+} Why is this button focusable? Keyboard access?
Attachment #644531 -
Flags: review?(jaws) → review-
Updated•12 years ago
|
Component: SocialAPI → Theme
Assignee | ||
Comment 3•12 years ago
|
||
Taking this as requested.
Assignee: mixedpuppy → jaws
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
(easier to track this in the social component, since we're going to need to keep track of the bugs that we need to uplift)
Assignee: jaws → nobody
Component: Theme → SocialAPI
Summary: Toolbar styling on Windows → Social toolbar styling on Windows
Updated•12 years ago
|
Assignee: nobody → jaws
Assignee | ||
Comment 5•12 years ago
|
||
This gets it close, but the borders on the [open=true] state aren't completely matching the :active state of other buttons on the toolbar yet. There is potentially a lot of cleanup in the CSS for the social toolbar button but I don't want to include it all for this bug.
Attachment #644531 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
This patch cleans up some of the CSS and gets the button to match the other Australis toolbar buttons in terms of styling.
Attachment #645959 -
Attachment is obsolete: true
Attachment #646233 -
Flags: review?(gavin.sharp)
Attachment #646233 -
Flags: review?(dao)
Assignee | ||
Comment 7•12 years ago
|
||
I noticed that the border-width was being increased in the "open" state, so I moved it to apply to all states of the button with a default "transparent" border-color.
Attachment #646233 -
Attachment is obsolete: true
Attachment #646233 -
Flags: review?(gavin.sharp)
Attachment #646233 -
Flags: review?(dao)
Attachment #646363 -
Flags: review?(dao)
Assignee | ||
Comment 8•12 years ago
|
||
Sorry for the multiple patches, this one moves the border-radius to apply for all states and fixes the values being used in the :hover state.
Attachment #646363 -
Attachment is obsolete: true
Attachment #646363 -
Flags: review?(dao)
Attachment #646425 -
Flags: review?(dao)
Comment 9•12 years ago
|
||
Comment on attachment 646425 [details] [diff] [review] Patch v1.2 >diff --git a/browser/themes/winstripe/browser.css b/browser/themes/winstripe/browser.css >+#social-toolbar-button[open="true"] > .social-statusarea-container { >+ box-shadow: 0 1px 1px hsla(210,54%,20%,.1) inset, >+ 0 0 1px hsla(210,54%,20%,.2) inset, >+ /* allows winstripe-keyhole-forward-clip-path to be used for non-hover as well as hover: */ This comment seems unlikely to be relevant here? > #social-statusarea-user { >+ background-color: -moz-Dialog; >+ color: black; -moz-dialogtext? >+ cursor: default; Unnecessary.
Assignee | ||
Comment 10•12 years ago
|
||
Thanks for the feedback Gavin, I've addressed the issues you found. I also removed the cursor:pointer that was set on the #social-notification-icon-container since our toolbar buttons don't usually have cursor:pointer;
Attachment #646425 -
Attachment is obsolete: true
Attachment #646425 -
Flags: review?(dao)
Attachment #646460 -
Flags: review?(gavin.sharp)
Attachment #646460 -
Flags: review?(dao)
Comment 11•12 years ago
|
||
Comment on attachment 646460 [details] [diff] [review] Patch v1.3 r=me with the change we discussed on IRC (remove the extra two lines from the box-shadow style on #social-toolbar-button[open="true"] > .social-statusarea-container).
Attachment #646460 -
Flags: review?(gavin.sharp)
Attachment #646460 -
Flags: review?(dao)
Attachment #646460 -
Flags: review+
Assignee | ||
Comment 12•12 years ago
|
||
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b96a33ecbd2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•