776309 - 7" tablet should have tablet-ish interface

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The URL bar of 7" tablets should resemble tablets, and the tabs-tray should be a drawer instead of a sidebar.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): XLARGE rename

This patch makes XLARGE to be only V11+. This basically renames folders and changes makefile to reflect this.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): 7" tablet

This patch moves the files that are common between LARGE and XLARGE to LARGE. New XML files required for LARGE have been added.

Images that are LARGE specific have been newly added.

Note: browser_toolbar.xml and browser_toolbar_menu.xml are same f

Comment 3

[Sriram Ramasubramanian [:sriram]]

Note: browser_toolbar.xml and browser_toolbar_menu.xml are same for LARGE and XLARGE as they won't have h/w menu button.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): 7" tablet

Realized that hasPermanentMenuKey() was given the opposite value. Fixed that, and removed the unnecessary copies of browser_toolbar.xml and tabs_panel_toolbar.xml in LARGE and XLARGE folders.

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 644715 [details] [diff] [review]
Patch (2/2): 7" tablet

Review of attachment 644715 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Note: I didn't really examine the binary file additions; I assume they are copies of existing assets.  If there are any that I should look at more closely, let me know.

Comment 6

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/abdc19758652
http://hg.mozilla.org/integration/mozilla-inbound/rev/48077fafad8c

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 644710 [details] [diff] [review]
Patch (1/2): XLARGE rename

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: pre-honeycomb tablets will have tablet ui -- though we won't support it anymore.
Testing completed (on m-c, etc.): Landed on m-i on 07/23
Risk to taking this patch (and alternatives if risky): This is just renaming of the folder names to be 11+
String or UUID changes made by this patch: None.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 644715 [details] [diff] [review]
Patch (2/2): 7" tablet

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: 7" tablets will have phone UI.
Testing completed (on m-c, etc.): Landed in m-i on 07/23
Risk to taking this patch (and alternatives if risky): None. This is 7" tablets only.
String or UUID changes made by this patch: None.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 644710 [details] [diff] [review]
Patch (1/2): XLARGE rename

[Triage Comment]
We're supporting all tablet sizes in FN15. Please land on all branches.

Comment 10

[Aaron Train [:aaronmt]]

Verifying early on inbound, on my Galaxy Tab 2 7" I get the hybrid design (tablet bar/phone tab menu).

Comment 11

[Nick Cameron [:nrc]]

I had a play with this on the Nexus 7 - it looks good, I get the hybrid UI, and it is all pretty functional. The only issue I found (other than the tab preview issue, which I think is known) was that hit testing the menu button (with three vertical dots) is slightly off, it is more noticeable in landscape mode. When trying to hit the dots, it often mistakes this for hitting the tab dropdown, the hit test box seems to follow the box created by the bounding box of the tab dropdown, not the actual curve between the two buttons. I don't have an older nightly to test against, so not 100% sure these patches are the cause, but it is not a problem on Aurora.

Comment 12

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/6e3af4a361ac
https://hg.mozilla.org/releases/mozilla-aurora/rev/d09b7a8dbf35

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6fb04d935fb6
https://hg.mozilla.org/releases/mozilla-beta/rev/955dcf31914d

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/abdc19758652
https://hg.mozilla.org/mozilla-central/rev/48077fafad8c

Comment 15

[Aaron Train [:aaronmt]]

Verifying against the Galaxy Tab 2 7". More tablets for testing these changes would be nice.

Comment 16

[Adrian Tamas (:AdrianT)]

Verified on Galaxy Tab 2 7.0 running Android (4.0.4) on Firefox Mobile 16.0b5. Marking as verified on Firefox Mobile 16 also.