793480 - Opening link in new tab greys out back button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[ash.c.1741]

User Agent: Mozilla/5.0 (Android; Tablet; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120919064051

Steps to reproduce:

Hold down a link then select "Open link in new tab" on Asus Transformer TF300T


Actual results:

New link opens fine, current page remains in focus but page back button is greyed out and can't be used. Tapping any of the tabs, even the current one in focus, restores back button.


Expected results:

Back button should not grey out

Comment 1

[Aaron Train [:aaronmt]]

This may be a dupe of bug 790994 wherein the issue and solution may be the same.

Can we get this tracking 16 as it's a regression?

Comment 2

[Alex Keybl [:akeybl]]

It's important for us to figure out when this regression first occurred.

Aaron - please help with a regression range, and what devices are affected.
Sriram - our final beta is going to build Monday, so if this is a new regression, investigation needs to kick off ASAP.

Comment 4

[Aaron Train [:aaronmt]]

This is not new. This was introduced with the initial patches for tablet interfaces (at least for 7" tablets in my testing here via Nexus 7) via bug 776309; which landed on Aurora (16 at the time) on July 24th.

Comment 5

[Aaron Train [:aaronmt]]

Adding 776309 as blocking (at least for 7" tablets where I can reproduce), I can't find the culprit bug for larger tablets.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

(I dont know when we stopped sending "background" tab as a parameter from Gecko. Or actually did we?)
We were defaulting to disabling Back/Forward button on adding, removing tabs. This has been fixed by doing it only if its the selected tab.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 666279 [details] [diff] [review]
Patch

Seems like the right thing to do. This has been like this since back when this code was in Tabs.java

Comment 8

[Aaron Train [:aaronmt]]

I'll try this on inbound when it lands

Comment 9

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48724698ca34
and it lands.

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Aaron Train [:aaronmt] from comment #4)
> This is not new. This was introduced with the initial patches for tablet
> interfaces (at least for 7" tablets in my testing here via Nexus 7) via bug
> 776309; which landed on Aurora (16 at the time) on July 24th.

Given that, wontfixing for FF16. We can take this for the first time in FF17, since this doesn't meet our typical criteria for uplift.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - The risk looks very low, but can you add an approval request for aurora?

Comment 12

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 666279 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Been there for a long time.
User impact if declined: Back/Forward will be disabled unnecessarily when opening new tabs.
Testing completed (on m-c, etc.): Landed on m-i now.
Risk to taking this patch (and alternatives if risky): Low to none.
String or UUID changes made by this patch: None.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

removing regression window, there's a patch!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48724698ca34

Comment 15

[Sriram Ramasubramanian [:sriram]]

In Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/89f96cbcc3ef

Comment 16

[Adrian Tamas (:AdrianT)]

Verified on Firefox Mobile 17.0b1 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4)