776324 - remove support for RFC 2231 continuation parameters in HTTP header field parameters

Status: NEW

(Firefox :: File Handling, defect)

Description

[Julian Reschke]

RFC 2231 parameter continuations aren't needed in HTTP (which doesn't have MIME's line length restrictions), and aren't widely implemented (see http://greenbytes.de/tech/tc2231/#encoding-2231-cont -- they are unsupported in Safari, Chrome, and IE).

The existing code will need to be kept for MIME header field parsing (as long as the mail client uses nsMIMEHeaderParams) though.

Comment 1

[Julian Reschke]

Attachment: Proposed patch

Comment 2

[Jason Duell]

Comment on attachment 644750 [details] [diff] [review]
Proposed patch

Review of attachment 644750 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't look like a patch to remove support for RFC 2231 continuation parameters in HTTP header fields:  it looks like a patch to remove some old broken-but-long-supported content-disposition behaviors (like using 'name' instead of 'filename'.   Did you attach the right patch here Julian?

Comment 3

[Julian Reschke]

(In reply to Jason Duell (:jduell) from comment #2)
> Comment on attachment 644750 [details] [diff] [review]
> Proposed patch
> 
> Review of attachment 644750 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This doesn't look like a patch to remove support for RFC 2231 continuation
> parameters in HTTP header fields:  it looks like a patch to remove some old
> broken-but-long-supported content-disposition behaviors (like using 'name'
> instead of 'filename'.   Did you attach the right patch here Julian?

No, I did not. Sorry for the confusion :-)

Comment 4

[Julian Reschke]

(In reply to Julian Reschke from comment #3)
> No, I did not. Sorry for the confusion :-)

Actually, it was the correct patch applied to the wrong bug :-)