"ASSERTION: Forgot to check if this is a wrapper?" with Components.lookupMethod

RESOLVED FIXED in Firefox 17

Status

()

Core
XPConnect
--
critical
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: Jesse Ruderman, Unassigned)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla17
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17+ verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 644728 [details]
testcase (asserts fatally when loaded)

###!!! ASSERTION: Forgot to check if this is a wrapper?: 'IS_WRAPPER_CLASS(js::GetObjectClass(obj))', file ../../../dist/include/xpcpublic.h, line 70

Assertion failure: (DebugCheckWrapperClass(obj) && !js::GetReservedSlot(obj, 0).isDouble()), at /Users/jruderman/trees/mozilla-central/js/xpconnect/wrappers/XrayWrapper.cpp:440

Might be a regression from bug 774245.
(Reporter)

Comment 1

5 years ago
Created attachment 644729 [details]
stack traces
Blocks: 774245
tracking-firefox17: --- → ?
Same as bug 776333.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 776333
tracking-firefox17: ? → ---
(Reporter)

Comment 3

5 years ago
This testcase still asserts for me.
Status: RESOLVED → REOPENED
tracking-firefox17: --- → ?
Resolution: DUPLICATE → ---
Testcase still asserts even though bug 776333 is now resolved, so what's the impact here of this assert being tripped?  How does this manifest?  What's the ramification for the end user?  Trying to get a sense of the importance for tracking here.
Created attachment 650481 [details] [diff] [review]
Only create holders for WNs. v1

Fixed a stupid mistake. Flagging Blake for review.
Attachment #650481 - Flags: review?(mrbkap)
(In reply to Lukas Blakk [:lsblakk] from comment #4)
> Testcase still asserts even though bug 776333 is now resolved, so what's the
> impact here of this assert being tripped?  How does this manifest?  What's
> the ramification for the end user?  Trying to get a sense of the importance
> for tracking here.

We should track. Simple fix, and potential crashes etc if left unfixed.

Updated

5 years ago
Attachment #650481 - Flags: review?(mrbkap) → review+
Pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e0f55796e6f

(this is very low risk for bustage, so I don't think it's worth the try resources to do a push there)
https://hg.mozilla.org/mozilla-central/rev/4e0f55796e6f
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Already fixed, setting status & tracking for completeness in case there's fallout later for any reason.
status-firefox17: --- → fixed
tracking-firefox17: ? → +
Keywords: verifyme
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Verified the fix with the latest beta-debug build (id 20121017141413) on Mac OS X 10.7.5 and doesn't assert anymore.
Marking verified for Firefox 17.
status-firefox17: fixed → verified
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.