Main toolbox still shown with all toolbars hidden

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 17.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed, thunderbird17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When all toolbars are hidden through menu View > Toolbars the toolbox is still shown with a height of 41px.
(Assignee)

Comment 1

5 years ago
Created attachment 644756 [details] [diff] [review]
patch

This patch removes the toolbox's min-height and adds margins to the toolbar. I can't give a min-height to the toolbar because this let's grow the buttons to full height. So I gave the toolbar top- and bottom-margins to become the height we need for the Australis theme. On Win7 and OSX this is easy with only one button height. On XP and Linux with the big and small icons it's a little bit trickier.

I set the :only-of-type to apply only when one toolbar is set. When two toolbars are set they are taller than the minimum height and the margins aren't needed. The only drawback with this is, when two toolbars are defined (with Add toolbar in Customize window) and one is hidden, then the only visible toolbar has no margins. But I think it's really seldom someone uses this configuration.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #644756 - Flags: review?(bwinton)
Comment on attachment 644756 [details] [diff] [review]
patch

I like it.  r=me!

Thanks for the patch!
Attachment #644756 - Flags: review?(bwinton) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

5 years ago
Comment on attachment 644756 [details] [diff] [review]
patch

[Approval Request Comment]
Bug 763308 is in aurora and beta and I think it makes sense this patch can also land there to solve the issue.
Attachment #644756 - Flags: approval-comm-beta?
Attachment #644756 - Flags: approval-comm-aurora?
Comment on attachment 644756 [details] [diff] [review]
patch

This fixes a fairly annoying case in Australis, and is just a theme change, so I think pulling it forward is the right move here.
Attachment #644756 - Flags: approval-comm-beta?
Attachment #644756 - Flags: approval-comm-beta+
Attachment #644756 - Flags: approval-comm-aurora?
Attachment #644756 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/f91c69072cf6
https://hg.mozilla.org/releases/comm-aurora/rev/414a1fb495be
https://hg.mozilla.org/releases/comm-beta/rev/1a93a4c3cb2a

Had to unbitrot c-a and c-b a bit, so please confirm that I didn't mess it up. Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
status-thunderbird17: --- → fixed
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0

Comment 6

5 years ago
Is this in any way related to bug 748555 (I wait for the current nightly to test it on Win XP)? If not, can you look at it while in the toolbar code? ;)
(Assignee)

Comment 7

5 years ago
It isn't related to bug 748555. I'll comment in this bug.
You need to log in before you can comment on or make changes to this bug.