Closed Bug 776453 Opened 8 years ago Closed 8 years ago

Update httpd.js in Mozmill to use network.http.max-persistent-connections-per-server

Categories

(Testing Graveyard :: Mozmill, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: regression, Whiteboard: [mozmill-1.5.16+][mozmill-2.0+])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #776316 +++

> Bug 770331 changed a pref on us, and our Mozmill tests have been busted ever since.  We need to update the pref in our version of Mozmill to fix it.

So this is also true for our tests and we have to fix this bustage ASAP. I will check what we can do right away.
Blocks: 776316
Looks like the latest version on mozilla-central works perfectly for us. So I will get it synced and also can finally remove all the patching code around.
Whiteboard: [mozmill-1.5.16+][mozmill-2.0+]
Attached file Patch (1.5)
Pointer to Github pull-request
Attachment #644880 - Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/72 → Patch (1.5)
Attachment #644880 - Flags: review?(jhammel)
Blocks: 776470
I've tested this locally. Looks good to me.
Attached file Patch (2.0)
Pointer to Github pull-request
Comment on attachment 644897 [details]
Patch (2.0)

Yay, that we can load the httpd.js module now without having to make any modifications.
Attachment #644897 - Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/73 → Patch (2.0)
Attachment #644897 - Flags: review?(jhammel)
Attachment #644880 - Flags: review?(jhammel) → review+
Attachment #644897 - Flags: review?(jhammel) → review+
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Created attachment 644880 [details]
> Patch (1.5)
> 
> Pointer to Github pull-request

pushed https://github.com/mozautomation/mozmill/commit/05029f25c65a04d051e21cee97644e2b7d6a0791
(In reply to Henrik Skupin (:whimboo) from comment #4)
> Created attachment 644897 [details]
> Patch (2.0)
> 
> Pointer to Github pull-request

pushed https://github.com/mozautomation/mozmill/commit/4aabbe9c1642336c84e7aee3f12c11fb4c38827e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.