Last Comment Bug 776316 - Update Mozmill's httpd.js to use network.http.max-persistent-connections-per-server
: Update Mozmill's httpd.js to use network.http.max-persistent-connections-per-...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Mike Conley (:mconley)
:
:
Mentors:
Depends on: 776453
Blocks: 770331
  Show dependency treegraph
 
Reported: 2012-07-21 22:07 PDT by Mike Conley (:mconley)
Modified: 2012-07-24 13:51 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch to update our version of Mozmill (989 bytes, patch)
2012-07-21 22:09 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Backout patch for comm-central (989 bytes, patch)
2012-07-24 07:18 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Update Mozmill to 1.5.latest (97.41 KB, patch)
2012-07-24 07:19 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Update to Mozmill 1.5.16 (97.41 KB, patch)
2012-07-24 07:32 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Mozmill test fixes for 1.5.16 update (5.16 KB, patch)
2012-07-24 07:35 PDT, Mike Conley (:mconley)
sid.bugzilla: review+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) 2012-07-21 22:07:13 PDT
Bug 770331 changed a pref on us, and our Mozmill tests have been busted ever since.  We need to update the pref in our version of Mozmill to fix it.

Not sure if the Mozmill guys know about this one, so I'm Cc'ing Henrik.
Comment 1 Mike Conley (:mconley) 2012-07-21 22:09:03 PDT
Created attachment 644720 [details] [diff] [review]
Patch to update our version of Mozmill

This makes the Mozmill tests pass again for me locally. I'll push to try just to make sure though.
Comment 2 Henrik Skupin (:whimboo) 2012-07-22 02:44:08 PDT
Has the upstream httpd component gotten an update? If yes Mozmill should be updated to use the latest version of httpd.js.
Comment 3 Henrik Skupin (:whimboo) 2012-07-23 02:23:39 PDT
See bug 776453 which is now covering the mozmill core modules. I will have an updated version of Mozmill ready by today.
Comment 4 Mike Conley (:mconley) 2012-07-23 07:24:10 PDT
Landed with r=bustage-fix in comm-central as https://hg.mozilla.org/comm-central/rev/e76231334aff
Comment 5 Mike Conley (:mconley) 2012-07-23 07:45:12 PDT
Whoops - so, I made a few mistakes here:

1) I assumed we maintained a fork of Mozmill 1.5. This is not true, and we shouldn't be monkey patching our instance of it.
2) The Mozmill team is working on fixing this upstream for both 1.5 and 2.0. See bug 776453. When the fix for 1.5 lands, we should update our instance of Mozmill.

So I'm going to keep an eye on Bug 776453. When the 1.5 fix lands, I'll be backing out https://hg.mozilla.org/comm-central/rev/e76231334aff, and landing the update (after testing on Try of course).

Thanks to Sid for setting me straight on that one. :)
Comment 6 Mike Conley (:mconley) 2012-07-24 07:18:33 PDT
Created attachment 645288 [details] [diff] [review]
Backout patch for comm-central

Patch to back out the original fix.
Comment 7 Mike Conley (:mconley) 2012-07-24 07:19:53 PDT
Created attachment 645289 [details] [diff] [review]
Update Mozmill to 1.5.latest

Bring in Mozmill 1.5.latest
Comment 8 Mike Conley (:mconley) 2012-07-24 07:32:56 PDT
Created attachment 645298 [details] [diff] [review]
Update to Mozmill 1.5.16

Here's the update to 1.5.16
Comment 9 Mike Conley (:mconley) 2012-07-24 07:35:02 PDT
Created attachment 645300 [details] [diff] [review]
Mozmill test fixes for 1.5.16 update

The 1.5.16 update changes how we get access to the fake HttpServer. This patch brings us in line with those changes.

The try server build with all three of these patches can be found here:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f5f2bd8402cf

(The XPCShell failures are a known toolkit bug being actively worked on)
Comment 10 Mike Conley (:mconley) 2012-07-24 13:51:12 PDT
Backed out original patch from comm-central: https://hg.mozilla.org/comm-central/rev/927b4c1ae376

Landed Mozmill update: https://hg.mozilla.org/comm-central/rev/16bca5fa8f08
and test fixups: https://hg.mozilla.org/comm-central/rev/c2c87f2fd534

Thanks Sid!

Note You need to log in before you can comment on or make changes to this bug.