Closed Bug 776316 Opened 8 years ago Closed 8 years ago

Update Mozmill's httpd.js to use network.http.max-persistent-connections-per-server

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files, 2 obsolete files)

Bug 770331 changed a pref on us, and our Mozmill tests have been busted ever since.  We need to update the pref in our version of Mozmill to fix it.

Not sure if the Mozmill guys know about this one, so I'm Cc'ing Henrik.
This makes the Mozmill tests pass again for me locally. I'll push to try just to make sure though.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Has the upstream httpd component gotten an update? If yes Mozmill should be updated to use the latest version of httpd.js.
See bug 776453 which is now covering the mozmill core modules. I will have an updated version of Mozmill ready by today.
Landed with r=bustage-fix in comm-central as https://hg.mozilla.org/comm-central/rev/e76231334aff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Whoops - so, I made a few mistakes here:

1) I assumed we maintained a fork of Mozmill 1.5. This is not true, and we shouldn't be monkey patching our instance of it.
2) The Mozmill team is working on fixing this upstream for both 1.5 and 2.0. See bug 776453. When the fix for 1.5 lands, we should update our instance of Mozmill.

So I'm going to keep an eye on Bug 776453. When the 1.5 fix lands, I'll be backing out https://hg.mozilla.org/comm-central/rev/e76231334aff, and landing the update (after testing on Try of course).

Thanks to Sid for setting me straight on that one. :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Patch to back out the original fix.
Attachment #644720 - Attachment is obsolete: true
Attached patch Update Mozmill to 1.5.latest (obsolete) — Splinter Review
Bring in Mozmill 1.5.latest
Attachment #645289 - Attachment is obsolete: true
Here's the update to 1.5.16
The 1.5.16 update changes how we get access to the fake HttpServer. This patch brings us in line with those changes.

The try server build with all three of these patches can be found here:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f5f2bd8402cf

(The XPCShell failures are a known toolkit bug being actively worked on)
Attachment #645300 - Flags: review?(sagarwal)
Attachment #645300 - Flags: review?(sagarwal) → review+
Backed out original patch from comm-central: https://hg.mozilla.org/comm-central/rev/927b4c1ae376

Landed Mozmill update: https://hg.mozilla.org/comm-central/rev/16bca5fa8f08
and test fixups: https://hg.mozilla.org/comm-central/rev/c2c87f2fd534

Thanks Sid!
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.