Last Comment Bug 776474 - Make twitter account setup less fragile
: Make twitter account setup less fragile
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: 15 Branch
: x86 All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Florian Quèze [:florian] [:flo]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-23 03:27 PDT by thomas
Modified: 2012-07-23 13:02 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Patch (3.42 KB, patch)
2012-07-23 09:38 PDT, Florian Quèze [:florian] [:flo]
clokep: review+
bwinton: approval‑comm‑aurora+
bwinton: approval‑comm‑beta+
Details | Diff | Splinter Review

Description thomas 2012-07-23 03:27:28 PDT
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713224758

Steps to reproduce:

I tried to add more than one Twitter Account, but login was not possible for the second account.


Actual results:

I can only use one Twitter Account in the new Chat Tab. After authentication via Twitter API I get the following error:

"Error: Username mismatch" 


Expected results:

It would be nice, if I could use multiple Twitter Accounts
Comment 1 :aceman 2012-07-23 04:55:36 PDT
Were you able to create those 2 accounts in the account manager? If yes, then one of the accounts did not work?
Comment 2 thomas 2012-07-23 05:06:36 PDT
Ok, know it works for me too.. the problem was, that TB is case-sensitive and throws the error "User mismatch", if the username is not correct. Twitter is not as restrict here (not case-sensitive!), so maybe it would be better to change this in TB as well.
Comment 3 Florian Quèze [:florian] [:flo] 2012-07-23 09:38:33 PDT
Created attachment 644958 [details] [diff] [review]
Patch

Changes included in this patch:
- fix the case in account names instead of refusing to connect the account (fixes what's described in comment 2)
- ignore existing cookies when opening the authorization dialog. I suspect this fixes what was initially described in comment 0.
- prefill the input box in the authorization dialog.
Comment 4 Patrick Cloke [:clokep] 2012-07-23 09:44:39 PDT
Comment on attachment 644958 [details] [diff] [review]
Patch

This looks good! :) Thanks for fixing these annoyances.
Comment 6 Mike Conley (:mconley) 2012-07-23 13:02:25 PDT
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/7ebadaff038e

Note You need to log in before you can comment on or make changes to this bug.