Closed
Bug 776635
Opened 12 years ago
Closed 12 years ago
Allow use of JSRootedObject using only external headers
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(1 file)
3.84 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Currently, JS::Rooted<JSObject*> requires the full definition of JSObject to be available (due to RootMethods<JSObject*>::kind() calling JSObject::rootKind()). This patch switches to using a RootKind<T> template that is explicitly specialized in jspubtd.h for externally-visible pointer types, but still falls back on T::rootKind() for other pointer types so that we don't need to explicitly specialize on eg all subclasses of JSString or JSObject.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #645015 -
Flags: review?(wmccloskey)
Attachment #645015 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/33321a15636f
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/33321a15636f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•