Closed Bug 869517 Opened 7 years ago Closed 7 years ago

Fix JSFlatString RootKind compilation error when building with --enable-root-analysis

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23
Tracking Status
firefox22 --- wontfix
firefox23 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

When I build with --enable-root-analysis on OSX, I get the following compilation error because RootKind<JSFlatString *> is undefined:


../../dist/include/js/RootingAPI.h:382:46: error: incomplete type 'JSFlatString' named in nested name specifier
  static ThingRootKind rootKind() { return T::rootKind(); }
                                           ^~~
../../dist/include/js/RootingAPI.h:389:57: note: in instantiation of member function 'js::RootKind<JSFlatString *>::rootKind' requested here
  static ThingRootKind kind() { return RootKind<T *>::rootKind(); }
                                                      ^
../../dist/include/js/RootingAPI.h:490:54: note: in instantiation of member function 'js::RootMethods<JSFlatString *>::kind' requested here
      js::ThingRootKind kind = js::RootMethods<T>::kind();
                                                   ^
../../dist/include/js/RootingAPI.h:411:9: note: in instantiation of member function 'JS::Rooted<JSFlatString *>::commonInit' requested here
      commonInit(cx->thingGCRooters);
      ^
../../dist/include/js/RootingAPI.h:428:9: note: in instantiation of member function 'JS::Rooted<JSFlatString *>::init' requested here
      init(cx);
      ^
/Users/chris/Code/mozilla/central/dom/base/nsJSTimeoutHandler.cpp:188:29: note: in instantiation of member function 'JS::Rooted<JSFlatString *>::Rooted' requested here
JS::Rooted<JSFlatString*> expr(cx);
                          ^
../../dist/include/jspubtd.h:186:45: note: forward declaration of 'JSFlatString'
class                                       JSFlatString;
                                          ^
1 error generated.
Attachment #746471 - Flags: review?(wmccloskey)
Attachment #746471 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/51b1dc857800
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.