776726 - osx panel shows up black for a moment

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

social panels are styled white, but the default styling takes over for just a moment while opening the status panels.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: style patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I don't think this is the right way to go about fixing it. Is there a way to prevent the flash of blank background?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 645097 [details] [diff] [review]
style patch

Review of attachment 645097 [details] [diff] [review]:
-----------------------------------------------------------------

What would -moz-appearance:none; do here?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 645097 [details] [diff] [review]
style patch

Review of attachment 645097 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +3455,5 @@
>    max-height: 600px;
>    max-width: 400px;
>  }
>  
>  #social-notification-panel .panel-arrowcontent {

Can you change this and the other selectors for #social-notification-panel to use child selectors as part of this patch?

@@ +3459,5 @@
>  #social-notification-panel .panel-arrowcontent {
>    margin: -4px 0 0 0;
>    padding: 0;
>    border-radius: 0px;
> +  background: white;

I talked this over with Gavin and Shane, and this will be fine for Fx16.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Changed from "background" to "background-color" on checkin:
https://hg.mozilla.org/mozilla-central/rev/f263db41eaa9

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #5)
> Changed from "background" to "background-color" on checkin:

Which broke things!
Fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d0e381119c9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d0e381119c9