776836 - some garbage drawn when zooming in

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Load https://bug775562.bugzilla.mozilla.org/attachment.cgi?id=643857 and zoom in/out a few times. I get some garbage drawn at the top at some zooms.

Verified that it is caused by bug 773100.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

I can confirm this against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120728030524 with HWA off only.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: single green div testcase

Most obvious when zooming out then in.
Also visible when zooming in a couple of times.

Comment 3

[Karl Tomlinson (:karlt)]

8a9f2d2b75d4 was also transplanted to aurora so I assume we need to track this on 16 also.

Comment 4

[Karl Tomlinson (:karlt)]

There are
"###!!! ASSERTION: bad aListVisibleBounds: 'r.GetBounds().IsEqualInterior(aListVisibleBounds)', file [...]/layout/base/nsDisplayList.cpp, line 487"
failures with and without 8a9f2d2b75d4.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Lawrence mentioned in triage that tabbing away and tabbing back restores the expected appearance so we might have a work around to provide if the fix for this isn't available quickly.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

I haven't found a good way to test this.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e52c71762ca4

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 649158 [details] [diff] [review]
fix

Review of attachment 649158 [details] [diff] [review]:
-----------------------------------------------------------------

Very low risk. We just invalidate more aggressively when zooming. Fixes a pretty bad rendering regression when zooming.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e52c71762ca4

Comment 10

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/56e05fc79712

Comment 12

[Simona Badau, Desktop QA]

Verified that zooming in and zooming out works properly (without any rendering issues) on Firefox 16 beta 4 - on Windows 7, Ubuntu 12.04 and Mac OS X 10.7.
Verified with hardware acceleration enabled/disabled using the test cases provided in this bug (in the Description and in Comment 2) and in Bug 778701. 

Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0

Comment 13

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 17 beta 1 - zooming in and out works properly (without any rendering issues) on Windows 7, Ubuntu 12.04 and Mac OS X 10.7.

Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Comment 14

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old