776866 - "Open containing folder" button may open the file manager multiple times

Status: REOPENED

(Firefox :: Downloads Panel, defect)

Description

[Dan Wolff]

Using Firefox Aurora 16.0a2 on Ubuntu.

Steps to reproduce:

1. Download a file
2. Open the download manager
3. Click the "Open containing folder" icon which looks like a search icon (magnifying glass)
4. Since nothing happens, click it a few more times

Expected:

* To be able to search downloads.
* To not have lots of windows showing the folder.

What happens:

* Several Nautilus windows with that folder appear after a while.

Suggested solutions:

* Use an icon which makes it clear that it'll open a folder (maybe something which includes a folder in it?)
* Allow double-clicking the icon without opening two windows
* Give instant feedback that the icon has been pressed (similar to other buttons)

Comment 1

[Marco Bonardo [:mak]]

I think we already have a bug for this, though not sure. The plan was indeed to replace the magnifier icon that is completely unclear.

Comment 2

[eyal gruss]

how about a folder icon?

Comment 3

[:Paolo Amadini]

We've indeed switched to a folder icon as part of bug 756542. The change will be
available in Nightly builds together with a panel redesign. As of now, this is
only waiting for the work in bug 747903 to be completed.

Comment 4

[Dão Gottwald [:dao]]

If some bug with a broader scope is expected to fix this one, please use dependency relations to document this, such that we don't lose track of this specific issue and can verify that it's fixed once the other bug lands.

Bug 756542 appears to be something else entirely.

Comment 5

[:Paolo Amadini]

(In reply to Dão Gottwald [:dao] from comment #4)
> If some bug with a broader scope is expected to fix this one, please use
> dependency relations to document this, such that we don't lose track of this
> specific issue and can verify that it's fixed once the other bug lands.

Will do, thanks!

> Bug 756542 appears to be something else entirely.

It was bug 760607 indeed.

Comment 6

[david.smitmanis]

Status in current Nightly (newest build September 5th):

The looking glass is replaced by a folder icon.
The icon gives feedback that it's clicked (the effect is rather subtle though)
Doubleclicking on the icon doesn't open multiple file browsers on Windows anyway.

However, there's a separate bug here: doubleclicking fast on the icon will start an additional download of the local file. I'll check whether this issue is already reported and file a new bug if it's not.

Suggestion: check whether the issues in the original report are gone in Linux as well (maybe the multiple file browser instance is an issue with Nautilus only). If so, close the bug.

Comment 7

[david.smitmanis]

Further update: doubleclicking the folder icon does indeed open two instances of Nautilus on Ubuntu still. Triple clicking opens three and so on.

Comment 8

[Girish Sharma [:Optimizer]]

(In reply to david.smitmanis from comment #7)
> Further update: doubleclicking the folder icon does indeed open two
> instances of Nautilus on Ubuntu still. Triple clicking opens three and so on.

Not on Windows 7

Comment 9

[Marco Bonardo [:mak]]

So basically what's left here is that it may open Nautilus multiple times.

In future please report a single bug per report, that simplifies management.

Comment 10

[Dan Wolff]

On Ubuntu Unity, Aurora 2012-10-14: Clicking the folder icon now does *nothing* for me. No Nautilus folder opens at all, regardless of the number of times I click.

Comment 11

[Marco Bonardo [:mak]]

(In reply to Dan Wolff from comment #10)
> On Ubuntu Unity, Aurora 2012-10-14: Clicking the folder icon now does
> *nothing* for me. No Nautilus folder opens at all, regardless of the number
> of times I click.

please file a separate bug.

Comment 13

[Junye Ji]

I can reproduce a related variant of this on a current Fedora GNOME system, and
the logs suggest a specific timeout/fallback race rather than a double-click.

Observed environment:

• Fedora Linux 44 Workstation
• GNOME on Wayland
• Firefox 151.0.2, RPM package
• Nautilus 50.1
• xdg-desktop-portal 1.21.2
• xdg-desktop-portal-gnome 50.0
• xdg-desktop-portal-gtk 1.15.3
• Default directory handler: org.gnome.Nautilus.desktop

Steps:

1. Close all Nautilus windows.
2. Quit the Nautilus background service with nautilus -q.
3. Start Firefox.
4. Download a small file.
5. Open the downloads panel and single-click the folder icon / "Show in
   Folder" once.

Actual result:

Two Nautilus windows can open. One selects the downloaded file, and the other
opens the containing directory.

Relevant sanitized journalctl --user -b excerpt:

May 26 22:55:03 systemd: Started dbus-:[e-mail].
May 26 22:55:03 org.gnome.Nautilus: Connecting to org.freedesktop.Tracker3.Miner.Files
May 26 22:55:04 firefox.desktop: Failed to query file manager via ShowItems: Timeout was reached
May 26 22:55:05 systemd: Started dbus-:[e-mail].
May 26 22:55:05 org.gnome.Nautilus: g_file_equal: assertion 'G_IS_FILE (file2)' failed
May 26 22:55:05 org.gnome.Nautilus: g_file_equal: assertion 'G_IS_FILE (file2)' failed

The local system locale rendered the timeout as 已到超时限制.

This matches the GTK reveal path in nsGIOService.cpp: Firefox calls
org.freedesktop.FileManager1.ShowItems, uses
widget.gtk.file-manager-show-items-timeout-ms as the D-Bus call timeout
(default 1000 ms), and on failure falls back to opening the parent directory
directly via RevealDirectory(file, true). If Nautilus cold-starts slowly,
the fallback opens the directory, and the original ShowItems request can still
complete afterward, producing a second window.

Increasing widget.gtk.file-manager-show-items-timeout-ms to 5000 appears to
be the local workaround to validate.

Full reproduction notes and links:

https://github.com/JJYYY-JJY/linux-desktop-bug-repros/tree/main/firefox-nautilus-double-open