776972 - Increase bugs_activity primary key size to INTSERIAL for future growth

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch to increase primary key size of bugs_activity (v1)

Currently bugs_activity's primary key is MEDIUMSERIAL which is limited to ~8.3 million rows. Several large Bugzilla installations will hit that limit sooner rather than later so the size needs to be increases to INTSERIAL.

Patch attached

Comment 1

[Frédéric Buclin]

Comment on attachment 645360 [details] [diff] [review]
Patch to increase primary key size of bugs_activity (v1)

Already converted DB won't see this change. You must fix them too.

Comment 2

[Frédéric Buclin]

dkl: would you agree to fix longdescs at the same time?

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to increase primary key size of bugs_activity (v2)

New patch that will update a previous installed primary key as well.

As for longdescs, I think we should fix that as well. I will file a separate bug for that.

dkl

Comment 4

[Frédéric Buclin]

Comment on attachment 645364 [details] [diff] [review]
Patch to increase primary key size of bugs_activity (v2)

>=== modified file 'Bugzilla/Install/DB.pm'

All you have to do is to write:

  $dbh->bz_add_column('bugs_activity', 'id', {TYPE => 'INTSERIAL', NOTNULL => 1, PRIMARYKEY => 1});
  # Fix installations which had MEDIUMSERIAL instead of INTSERIAL for bugs_activity.id.
  $dbh->bz_alter_column('bugs_activity', 'id', {TYPE => 'INTSERIAL', NOTNULL => 1, PRIMARYKEY => 1});

Not yet upgraded installations will see bz_add_column() while already upgraded installations will see bz_alter_column(). These two methods already do checks themselves to know if they should be executed or not. This would be cleaner IMO than what your patch proposes (avoids the IF ELSE block).

Comment 5

[David Lawrence [:dkl]]

Attachment: Patch to increase primary key size of bugs_activity (v3)

Yes that is cleaner. Should have thought of that before ;) Here is simpler patch.

dkl

Comment 6

[Frédéric Buclin]

Comment on attachment 645406 [details] [diff] [review]
Patch to increase primary key size of bugs_activity (v3)

r=LpSolit

Comment 7

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/Install/DB.pm
modified Bugzilla/DB/Schema.pm                            
Committed revision 8302