Closed Bug 777003 Opened 13 years ago Closed 13 years ago

back button shouldn't just history.back()

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2012-08-16

People

(Reporter: krupa.mozbugs, Assigned: potch)

References

Details

(Whiteboard: [janus])

steps to reproduce: 1. Tester is not logged in 2. Load https://marketplace.allizom.org/en-US/login 3. Log in using your browserID account 4. Navigate to the details page of any of the apps featured on the homepage 5. Click < in the breadcrumb expected behavior: User goes back to the homepage observed behavior: User goes back to the homepage and then to the Login page screencast: http://screencast.com/t/epvblqEfz6
Whiteboard: [janus]
We'll need to figure out a better solution for that back button than history.back().
Summary: Clicking < in breadcrumb logs out user → back button shouldn't just history.back()
I used to keep track of the "previous page" but that's really gross and not a thing we should do. Keeping an internal stack should work fine though. But the thing is going "back" shouldn't always take you "back" (in the case of the previous page behind a 301/302).
Blocks: 766199
I'm going to take a look at this.
Assignee: nobody → thepotch
Target Milestone: --- → 2012-08-09
Target Milestone: 2012-08-09 → 2012-08-16
https://github.com/mozilla/zamboni/commit/52cfaf2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified as fixed in https://marketplace-dev.allizom.org/ on FF20 (Win 7) Postfix screencast http://screencast.com/t/WMRj13X8xi Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.