[webconsole] implement the dark theme for the webconsole toolbar

RESOLVED FIXED in Firefox 17

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 17
x86
All
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(4 attachments, 4 obsolete attachments)

Assignee

Description

7 years ago
No description provided.
Assignee

Updated

7 years ago
Depends on: 688981
Assignee

Comment 1

7 years ago
Posted patch v0.007 (obsolete) — Splinter Review
Only tested on osx so far
Assignee

Comment 2

7 years ago
Screenshot: http://i.imgur.com/L0EKY.png
Posted image screenshot - ubuntu 12.04 (obsolete) —
Paul: this is the screenshot you asked for.

Do note customizations: I use the ambiance theme and I use large font sizes.

Thanks for the patch! It looks great on Macs.
Assignee

Comment 4

7 years ago
Thank you Mihai. Can you please take another screenshot with the Global Toolbar + Web Console?

Thank you.
Updated the screenshot.
Attachment #645788 - Attachment is obsolete: true
Assignee

Comment 6

7 years ago
Could someone take a screenshot of this patch on Windows?
Builds are available here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/prouget@mozilla.com-3a165fc4f9de/

Mihai, do unchecked buttons look ok?
Assignee

Comment 8

7 years ago
(In reply to Sören Hentzschel from comment #7)
> @Paul, screenshot on Windows 7:
> http://s14.directupload.net/images/120725/9auirw8a.png

Thank you Sören.
(In reply to Paul Rouget [:paul] from comment #6)
> Could someone take a screenshot of this patch on Windows?
> Builds are available here:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/prouget@mozilla.
> com-3a165fc4f9de/
> 
> Mihai, do unchecked buttons look ok?

Nope. :(

They look very similar to the Win7 screenshot.
Assignee

Comment 10

7 years ago
Posted patch v1 (obsolete) — Splinter Review
Assignee

Updated

7 years ago
Attachment #645565 - Attachment is obsolete: true
Assignee

Updated

7 years ago
Attachment #651404 - Flags: review?(rcampbell)
Assignee

Updated

7 years ago
Attachment #651404 - Flags: ui-review?(shorlander)
Assignee

Comment 12

7 years ago
Posted image screenshot
Assignee: nobody → paul
Status: NEW → ASSIGNED
Comment on attachment 651404 [details] [diff] [review]
v1

Review of attachment 651404 [details] [diff] [review]:
-----------------------------------------------------------------

Looked into the patch and tested it. Buttons look good now on Ubuntu.

I'd only note the following test failure I got:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601909_remember_height.js | minimum page height is respected - Got 871, expected 870

Otherwise, the patch looks great! Thanks Paul!
Attachment #651404 - Flags: feedback+
Comment on attachment 651404 [details] [diff] [review]
v1

in HUDService.jsm:

   _initUI: function WC__initUI()
   {
     this.splitter = this.chromeDocument.createElement("splitter");
-    this.splitter.setAttribute("class", "web-console-splitter");
+    this.splitter.setAttribute("class", "devtools-horizontal-splitter");

any reason not to use the classList API here?

in gnomestripe/common.css:

+.devtools-toolbarbutton > .toolbarbutton-menubutton-button {
+  -moz-box-orient: horizontal;
+}
+

should that be .devtools-toolbarbutton[type=menu-button] ?

in gnomestripe/webconsole.css:

 
-.webconsole-clear-console-button > .toolbarbutton-icon {
-  display: none;
+/* WebConsole colored drops */
+
+.webconsole-filter-button,
+.webconsole-filter-button[checked=true] {
+  color: white!important;
 }

could add a space after white.

same in p/winstripe.

looks good!
Attachment #651404 - Flags: review?(rcampbell) → review+
Comment on attachment 651404 [details] [diff] [review]
v1

Review of attachment 651404 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

I noticed some things:

- There is a slow and noticeable transition effect on the menu buttons. I am not seeing this on any of the other devtools buttons. Or maybe it is less obvious?
- It is hard to see the black dot icon on "Net"

Windows:
- I only saw this on Windows: the filter field changes width when you start typing in it
Attachment #651404 - Flags: ui-review?(shorlander) → ui-review-
(In reply to Stephen Horlander from comment #16)
> Windows:
> - I only saw this on Windows: the filter field changes width when you start
> typing in it

Sounds like bug 767377.
Assignee

Comment 18

7 years ago
(In reply to Stephen Horlander from comment #16)
> - There is a slow and noticeable transition effect on the menu buttons. I am
> not seeing this on any of the other devtools buttons. Or maybe it is less
> obvious?

It's not a transition. It's just that we go through 3 steps: unchecked, over, checked.
You'll see the same think with the [style] button in the inspector.

> - It is hard to see the black dot icon on "Net"

Any recommendation for the color? #FF0066?

> Windows:
> - I only saw this on Windows: the filter field changes width when you start
> typing in it

Not directly related to this patch. But I can fix it.
Assignee

Comment 19

7 years ago
Posted patch v1.1 (obsolete) — Splinter Review
- fixed the test failure
- addressed rob's comments
- added a light ring around the dark drop for better contrast
- fixed the Windows resize
Assignee

Updated

7 years ago
Attachment #651404 - Attachment is obsolete: true
Assignee

Updated

7 years ago
Attachment #654671 - Flags: review?(rcampbell)
Assignee

Comment 20

7 years ago
Posted patch v1.1Splinter Review
rebased
Assignee

Updated

7 years ago
Attachment #654671 - Attachment is obsolete: true
Attachment #654671 - Flags: review?(rcampbell)
Assignee

Comment 22

7 years ago
It's green. Let's land that.
Whiteboard: [land-in-fx-team]
Assignee

Comment 23

7 years ago
https://hg.mozilla.org/integration/fx-team/rev/9ea94325f9f5
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9ea94325f9f5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.