Closed Bug 777188 Opened 8 years ago Closed 2 years ago

Tracking: Audit usage of "parentprocessmessagemanager"

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Unassigned)

References

(Blocks 1 open bug)

Details

See bug 776825.  Apparently several folks wrote code under the mistaken assumption that there's only one content process, or that this mm somehow sends messages to the "right" content process.  It doesn't, it broadcasts to all processes.

http://mxr.mozilla.org/mozilla-central/search?string=parentprocessmessagemanager

I can't really think of a case in which we should ever broadcast a message to all content processes at this level.  Instead, when specific subprocesses make requests to JS services, the services need to save the .target (bug 776825 comment 4) and only reply to that.
xul-fennec has two remaining users of the parentprocessmessagemanager that we don't have to care about.

Given the fact that *every* *single* *user* *of* *ppmm* shot itself in the foot with the giant ppmm footgun, I think we need to either forbid JS proxies or fix the hell out of that interface.
No longer depends on: 777207
Oh sorry Gene --- my comment was probably confusing: I thought you had added a dependency I forgot to add, but now I see you removed it and added it back :).  So, thanks for adding it back! ;)
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Oh sorry Gene --- my comment was probably confusing: I thought you had added
> a dependency I forgot to add, but now I see you removed it and added it back
> :).  So, thanks for adding it back! ;)

Cjones - Your guessing is right! I was thinking I should add the dependencies for both issues to keep track of them. ;) Btw, thanks very much for the quick review!
blocking-basecamp: --- → ?
Summary: Audit usage of "parentprocessmessagemanager" → Tracking: Audit usage of "parentprocessmessagemanager"
blocking-basecamp: ? → ---
Hey Blake, do you think we can close this out?
Flags: needinfo?(mrbkap)
Yeah.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mrbkap)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.