Created attachment 645657 [details] [diff] [review] Patch Cjones, The following summarizes what I've done in this patch: 1. To address this issue, use |aMessage.target| to send message instead of |ppmm|. 2. If you don't mind, I also did some minor refactoring things for |Return:OK| and |Return:KO| to make codes cleaner and shorter. 3. Note that in the |this._sendAsyncMessage()|, I did a sanity check for |aMessageManager| which shouldn't be null (please let me know if you think it's too strict). 4. No need to check if |aMessageName| or |json| is null because they've already been handled in the switch case (i.e. throw NS_ERROR_NOT_IMPLEMENTED). Thanks for your review! Gene
5 years ago
Created attachment 645993 [details] [diff] [review] Patch for Check-in Just a merge with the latest codes. Cjones has already had review+ on these changes.