777207 - Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Cjones,

The following summarizes what I've done in this patch:

1. To address this issue, use |aMessage.target| to send message instead of |ppmm|.
2. If you don't mind, I also did some minor refactoring things for |Return:OK| and |Return:KO| to make codes cleaner and shorter.
3. Note that in the |this._sendAsyncMessage()|, I did a sanity check for |aMessageManager| which shouldn't be null (please let me know if you think it's too strict).
4. No need to check if |aMessageName| or |json| is null because they've already been handled in the switch case (i.e. throw NS_ERROR_NOT_IMPLEMENTED).

Thanks for your review!

Gene

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch for Check-in

Just a merge with the latest codes. Cjones has already had review+ on these changes.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfed91df3940

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/bfed91df3940