The default bug view has changed. See this FAQ.

Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: Gene Lian (I already quit Mozilla))

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → clian
Blocks: 749551
No longer blocks: 777188
(Assignee)

Updated

5 years ago
Blocks: 777188
(Assignee)

Updated

5 years ago
Summary: AlarmService should use "activities" or "system messages", or not broadcast information to all content processes → Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes
(Assignee)

Comment 1

5 years ago
Created attachment 645657 [details] [diff] [review]
Patch

Cjones,

The following summarizes what I've done in this patch:

1. To address this issue, use |aMessage.target| to send message instead of |ppmm|.
2. If you don't mind, I also did some minor refactoring things for |Return:OK| and |Return:KO| to make codes cleaner and shorter.
3. Note that in the |this._sendAsyncMessage()|, I did a sanity check for |aMessageManager| which shouldn't be null (please let me know if you think it's too strict).
4. No need to check if |aMessageName| or |json| is null because they've already been handled in the switch case (i.e. throw NS_ERROR_NOT_IMPLEMENTED).

Thanks for your review!

Gene
Attachment #645657 - Flags: review?(jones.chris.g)
Attachment #645657 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 645993 [details] [diff] [review]
Patch for Check-in

Just a merge with the latest codes. Cjones has already had review+ on these changes.
Attachment #645657 - Attachment is obsolete: true
Attachment #645993 - Flags: review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfed91df3940
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bfed91df3940
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.