Last Comment Bug 777207 - Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes
: Alarm API - AlarmService should use "activities" or "system messages", or not...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Gene Lian [:gene] (I already quit Mozilla)
:
Mentors:
Depends on:
Blocks: 777188 alarm-api
  Show dependency treegraph
 
Reported: 2012-07-24 18:39 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-07-27 08:57 PDT (History)
4 users (show)
airpingu: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (5.83 KB, patch)
2012-07-24 23:05 PDT, Gene Lian [:gene] (I already quit Mozilla)
cjones.bugs: review+
Details | Diff | Splinter Review
Patch for Check-in (5.83 KB, patch)
2012-07-25 19:05 PDT, Gene Lian [:gene] (I already quit Mozilla)
airpingu: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-24 18:39:42 PDT

    
Comment 1 Gene Lian [:gene] (I already quit Mozilla) 2012-07-24 23:05:43 PDT
Created attachment 645657 [details] [diff] [review]
Patch

Cjones,

The following summarizes what I've done in this patch:

1. To address this issue, use |aMessage.target| to send message instead of |ppmm|.
2. If you don't mind, I also did some minor refactoring things for |Return:OK| and |Return:KO| to make codes cleaner and shorter.
3. Note that in the |this._sendAsyncMessage()|, I did a sanity check for |aMessageManager| which shouldn't be null (please let me know if you think it's too strict).
4. No need to check if |aMessageName| or |json| is null because they've already been handled in the switch case (i.e. throw NS_ERROR_NOT_IMPLEMENTED).

Thanks for your review!

Gene
Comment 2 Gene Lian [:gene] (I already quit Mozilla) 2012-07-25 19:05:28 PDT
Created attachment 645993 [details] [diff] [review]
Patch for Check-in

Just a merge with the latest codes. Cjones has already had review+ on these changes.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-26 18:26:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfed91df3940

Note You need to log in before you can comment on or make changes to this bug.