Closed Bug 777207 Opened 9 years ago Closed 9 years ago

Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: cjones, Assigned: airpingu)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → clian
Blocks: alarm-api
No longer blocks: 777188
Blocks: 777188
Summary: AlarmService should use "activities" or "system messages", or not broadcast information to all content processes → Alarm API - AlarmService should use "activities" or "system messages", or not broadcast information to all content processes
Attached patch Patch (obsolete) — Splinter Review
Cjones,

The following summarizes what I've done in this patch:

1. To address this issue, use |aMessage.target| to send message instead of |ppmm|.
2. If you don't mind, I also did some minor refactoring things for |Return:OK| and |Return:KO| to make codes cleaner and shorter.
3. Note that in the |this._sendAsyncMessage()|, I did a sanity check for |aMessageManager| which shouldn't be null (please let me know if you think it's too strict).
4. No need to check if |aMessageName| or |json| is null because they've already been handled in the switch case (i.e. throw NS_ERROR_NOT_IMPLEMENTED).

Thanks for your review!

Gene
Attachment #645657 - Flags: review?(jones.chris.g)
Attachment #645657 - Flags: review?(jones.chris.g) → review+
Just a merge with the latest codes. Cjones has already had review+ on these changes.
Attachment #645657 - Attachment is obsolete: true
Attachment #645993 - Flags: review+
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bfed91df3940
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.