777242 - Rename utils.assertElementVisible() to utils.isDisplayed()

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is no need to assert in this method. We now have the assertions module which gives us way nicer feedback. Also with this change tests could check first if an element is visible before clicking on it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Actually this patch depends on bug 777237.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Comment on attachment 645662 [details] [diff] [review]
Patch v1

I like it! Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/2934fad7bfa2 (default)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on other branches except esr10 which needs another patch:

http://hg.mozilla.org/qa/mozmill-tests/rev/b885b966b649 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/9a8c5efaf089 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/3382269187e1 (release)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch (backport esr10)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

And landed on esr10:
http://hg.mozilla.org/qa/mozmill-tests/rev/bd97debc7601