The default bug view has changed. See this FAQ.

Rename utils.assertElementVisible() to utils.isDisplayed()

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox17 fixed, firefox-esr10 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
There is no need to assert in this method. We now have the assertions module which gives us way nicer feedback. Also with this change tests could check first if an element is visible before clicking on it.
(Assignee)

Comment 1

5 years ago
Created attachment 645662 [details] [diff] [review]
Patch v1

Actually this patch depends on bug 777237.
Attachment #645662 - Flags: review?(dave.hunt)
Comment on attachment 645662 [details] [diff] [review]
Patch v1

I like it! Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/2934fad7bfa2 (default)
Attachment #645662 - Flags: review?(dave.hunt) → review+

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → affected
status-firefox16: --- → affected
status-firefox17: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 3

5 years ago
Landed on other branches except esr10 which needs another patch:

http://hg.mozilla.org/qa/mozmill-tests/rev/b885b966b649 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/9a8c5efaf089 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/3382269187e1 (release)
status-firefox14: affected → fixed
status-firefox15: affected → fixed
status-firefox16: affected → fixed
(Assignee)

Comment 4

5 years ago
Created attachment 646090 [details] [diff] [review]
Patch (backport esr10)
Attachment #646090 - Flags: review?(dave.hunt)

Updated

5 years ago
Attachment #646090 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 5

5 years ago
And landed on esr10:
http://hg.mozilla.org/qa/mozmill-tests/rev/bd97debc7601
status-firefox-esr10: affected → fixed
You need to log in before you can comment on or make changes to this bug.