777510 - DOM events can be triggered for wrong document

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Search "united states" in the AwesomeScreen
2) Click the first Google result
3) Once the reader icon appears in the URL bar, click it
4) Once "Loading..." appears, click back twice (to return to the Google results page)
5) Wait until the Readability parsing has finished

Expected result:
Nothing happens

Actual result:
When the Readability parse completes, the title for the Google results page is changed to "United States - Wikipedia...".

This bug is a side effect of making Readability async (bug 775346). I assume this is happening because of this callback: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutReader.js#253.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Make sure DOM events match current document

If some page (in this case, about:reader) fires document events, we should make sure the document is the one being shown.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 645895 [details] [diff] [review]
Make sure DOM events match current document

The change looks fine, though I'm a little surprised that the DOMTitleChanged event is still dispatched to the browser after navigating away from the document.

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/038c90c22adf

Comment 4

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/mozilla-central/rev/038c90c22adf

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 645895 [details] [diff] [review]
Make sure DOM events match current document

[Approval Request Comment]
Bug caused by (feature/regressing bug #): revealed by bug 775346
User impact if declined: wrong title can be shown for page after reader mode icon is clicked
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 6

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/af19c92f21f9

Comment 7

[Adrian Tamas (:AdrianT)]

Verified fix on: Firefox Mobile 16 beta 2, Nightly 18.0a1 2012-09-04 and Aurora 17.0a2 2012-09-05 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4)