Jelly Bean introduces a lot more API for accessibility, without supporting it we cannot take advantage of some of the JB accessibility features like flick navigation and improved explore by touch.
Depends on: 775720
OS: Linux → Android
Hardware: x86_64 → All
OS: Android → Linux
Hardware: All → x86_64
Created attachment 645969 [details] [diff] [review] Add Jelly Bean accessibility features to Java layer. Going to sleep on this before sending it out for review.
Comment on attachment 645969 [details] [diff] [review] Add Jelly Bean accessibility features to Java layer. OK, I could commit to this...
Attachment #645969 - Flags: review?(mbrubeck)
Attachment #645969 - Flags: review?(mbrubeck) → review+
In addition to this patch needing heavy rebasing, it also has a compile failure now at this line: final LayerView view = GeckoApp.mAppContext.getLayerController().getView(); in geckoAccessibility.java. Looks like other bugs pulled out something from under it and the method to get the layer view must be changed. Just a heads-up, I haven't actually tried to solve this.
LayerController was folded into GeckoLayerClient, so you'll need to replace that line with final LayerView view = GeckoApp.mAppContext.getLayerClient().getView(); Note that bug 781220 will further refactor some of this code and the line will have to be changed to final LayerView view = GeckoApp.mAppContext.getLayerView(); If you land first I can update the patches in bug 781220, but just a heads-up.
Created attachment 652964 [details] [diff] [review] Bug 777560 - Add Jelly Bean accessibility features to Java layer. Rebased. Compiles, but I am not sure if this is before or after kats's refactor.
Attachment #645969 - Attachment is obsolete: true
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.