Closed Bug 777560 Opened 7 years ago Closed 7 years ago

Add Jelly Bean accessibility support

Categories

(Firefox for Android :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 17

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Jelly Bean introduces a lot more API for accessibility, without supporting it we cannot take advantage of some of the JB accessibility features like flick navigation and improved explore by touch.
Depends on: 775720
Keywords: access
OS: Linux → Android
Hardware: x86_64 → All
Blocks: 773749
OS: Android → Linux
Hardware: All → x86_64
Going to sleep on this before sending it out for review.
Comment on attachment 645969 [details] [diff] [review]
Add Jelly Bean accessibility features to Java layer.

OK, I could commit to this...
Attachment #645969 - Flags: review?(mbrubeck)
Attachment #645969 - Flags: review?(mbrubeck) → review+
In addition to this patch needing heavy rebasing, it also has a compile failure now at this line:

            final LayerView view = GeckoApp.mAppContext.getLayerController().getView();

in geckoAccessibility.java. Looks like other bugs pulled out something from under it and the method to get the layer view must be changed.

Just a heads-up, I haven't actually tried to solve this.
LayerController was folded into GeckoLayerClient, so you'll need to replace that line with

final LayerView view = GeckoApp.mAppContext.getLayerClient().getView();

Note that bug 781220 will further refactor some of this code and the line will have to be changed to

final LayerView view = GeckoApp.mAppContext.getLayerView();

If you land first I can update the patches in bug 781220, but just a heads-up.
Rebased. Compiles, but I am not sure if this is before or after kats's refactor.
Attachment #645969 - Attachment is obsolete: true
Assignee: nobody → eitan
https://hg.mozilla.org/mozilla-central/rev/3e0e57eb237a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.