777673 - next-/prev-unstarred shortcuts skip a failure after starring twice with onlyunstarred=1

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

1) Go to https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1
2) Press 'k'
3) Star the first failure (click on the suggested bug star, then the quickstar button)
4) Press 'k'
5) Star this failure
6) Press 'k'

Expected:
After step #6, the first visible failure is selected.

Actual:
After step #6, the second visible failure is selected.

(Works fine at step #4, just broken for the second starring)

Must have not starred two in a row like this (without clicking), when I was testing bug 776692.

Comment 1

[Matt Brubeck (:mbrubeck)]

It looks like this happens when you have onlyunstarred=1 and the selected job is hidden because it is starred.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The next/prev-unstarred shortcut handler sorts the results by "result.order".  This does not work correctly when the selected result is hidden, because _buildHTMLForOS sets .order only for displayed results.  (For hidden results it will be uninitialized or set to an old incorrect value.)

This patch fixes this by changing _buildHTMLForOS to set .order on *all* of the results, before filtering out the hidden ones.  (Note: The "order" property is currently used only for these keyboard shortcuts, so this shouldn't affect anything else.)

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 646193 [details] [diff] [review]
patch

Looks good & works well locally for me :-)

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/ce4276d1d49c