777746 - Remove Tegra blacklist for Flash

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

On latest code this actually works (albeit a little buggy), so we should remove the blacklist.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I should clarify, we're only talking about Gingerbread/Froyo here.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't block Flash for Tegra on Gingerbread/Froyo

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b04613c43c9

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1b04613c43c9

Comment 5

[Tony Chung [:tchung]]

qawanted: take a look at tegra 2 (froyo or GB) devices and verify if flash is working.  

private build: http://dump.lassey.us/fennec-15.0.en-US.android-arm.apk

Comment 6

[Cristian Nicolae (:xti)]

The Flash was enabled on Tegra2 FroYo devices. However the performance is really poor, there are layouts issues when zooming, panning or rotating the device. Sometimes the OS freezes or even a restart may occur. More details can be found here: https://etherpad.mozilla.org/tegra2-flash

--
Device: LG Optimus 2X
OS: Android 2.2

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Cristian Nicolae (:xti) from comment #6)
> The Flash was enabled on Tegra2 FroYo devices. However the performance is
> really poor, there are layouts issues when zooming, panning or rotating the
> device. Sometimes the OS freezes or even a restart may occur. More details
> can be found here: https://etherpad.mozilla.org/tegra2-flash
> 
> --
> Device: LG Optimus 2X
> OS: Android 2.2

Can you guys compare the experience in Firefox to stock browser? In my testing locally there are a lot of issues with stock as well.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 646164 [details] [diff] [review]
Don't block Flash for Tegra on Gingerbread/Froyo

[Approval Request Comment]
Low risk, but will need some testing most likely especially for Beta

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 646164 [details] [diff] [review]
Don't block Flash for Tegra on Gingerbread/Froyo

Approving, let's get this landed and verified.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/375f160230b3

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

resetting the flags, looks like an accidental wipe of tracking flags.

Comment 12

[Adrian Tamas (:AdrianT)]

Flash plugin is enabled on Samsung Galaxy R running Android 2.3.4 for Firefox Mobile 15 beta 5 but the flash performance is very bad and resizes cause artifacts and have considerable lag.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

This still needs landing on Aurora (16)

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d7b893f5868