Closed Bug 703056 Opened 12 years ago Closed 12 years ago

Disable Flash on Tegra2 devices running Gingerbread because it doesn't paint


(Firefox for Android Graveyard :: General, defect, P2)



(firefox14 verified, blocking-fennec1.0 +, fennec11+)

Firefox 15
Tracking Status
firefox14 --- verified
blocking-fennec1.0 --- +
fennec 11+ ---


(Reporter: snorp, Assigned: snorp)



(Keywords: relnote, Whiteboard: sumo)


(1 file, 1 obsolete file)

On Tegra 2 devices running Gingerbread, Flash wants to paint to the SurfaceView using OpenGL (according to logs). This doesn't seem to work on birch, and the current theory is that you can't have a GLSurfaceView (our gecko rendering stuff) under what is effectively another GLSurfaceView (the plugin). It's unclear if there will be a reasonable way to solve this. I think ideally we'd have a way to force Flash into the conventional paint mode.
Assignee: nobody → snorp
tracking-fennec: --- → 11+
It would be wonderful to fix this, but when we're getting closer to release, we need to have some contingency plan. I propose that that plan is to disable flash entirely on tegra2 running gingerbread.
I agree, we should just disable it.
blocking-fennec1.0: --- → +
Summary: Flash doesn't paint on Tegra2 devices running Gingerbread → Disable Flash on Tegra2 devices running Gingerbread because it doesn't paint
Snorp, if you still agree with comment #2, lets just do it and relnote it.  Adding Jay to loop in product.  Should affect about 10% of phones in market.
Keywords: relnote
Whiteboard: sumo
Confirmed this with yesterday's m-c trunk on my Atrix running Gingerbread; flash doesn't paint correctly at all (a few gray squares on a youtube window, but that's it).
Blocks: 750968
Attached patch Block Flash on Tegra devices (obsolete) — Splinter Review
Attachment #620836 - Flags: review?(blassey.bugs)
Comment on attachment 620836 [details] [diff] [review]
Block Flash on Tegra devices

Review of attachment 620836 [details] [diff] [review]:

::: mobile/android/base/
@@ +213,5 @@
>      String[] getPluginDirectories() {
> +
> +        // An awful hack to detect Tegra devices. Easiest way to do it without spinning up a EGL context
> +        File tegraDriverPath = new File("/system/lib/hw/");
> +        if (tegraDriverPath.exists())

check for gingerbread
Attachment #620836 - Flags: review?(blassey.bugs) → review+
Attachment #620836 - Attachment is obsolete: true
Comment on attachment 620847 [details] [diff] [review]
Block Flash on Tegra devices

[Approval Request Comment]
Trivial patch, fixes very noticeable bug on a relatively popular set of devices. Mobile only.
Attachment #620847 - Flags: approval-mozilla-aurora?
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Attachment #620847 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Nightly 15.0a1 (2012-05-22)
                  Aurora 14.0a2 (2012-05-22)

Tegra device: LG Optimus 2X (2.2.2)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.