703056 - Disable Flash on Tegra2 devices running Gingerbread because it doesn't paint

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

On Tegra 2 devices running Gingerbread, Flash wants to paint to the SurfaceView using OpenGL (according to logs). This doesn't seem to work on birch, and the current theory is that you can't have a GLSurfaceView (our gecko rendering stuff) under what is effectively another GLSurfaceView (the plugin). It's unclear if there will be a reasonable way to solve this. I think ideally we'd have a way to force Flash into the conventional paint mode.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

It would be wonderful to fix this, but when we're getting closer to release, we need to have some contingency plan. I propose that that plan is to disable flash entirely on tegra2 running gingerbread.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

I agree, we should just disable it.

Comment 3

[JP Rosevear [:jpr]]

Snorp, if you still agree with comment #2, lets just do it and relnote it.  Adding Jay to loop in product.  Should affect about 10% of phones in market.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Confirmed this with yesterday's m-c trunk on my Atrix running Gingerbread; flash doesn't paint correctly at all (a few gray squares on a youtube window, but that's it).

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Block Flash on Tegra devices

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 620836 [details] [diff] [review]
Block Flash on Tegra devices

Review of attachment 620836 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +213,5 @@
>      String[] getPluginDirectories() {
> +
> +        // An awful hack to detect Tegra devices. Easiest way to do it without spinning up a EGL context
> +        File tegraDriverPath = new File("/system/lib/hw/gralloc.tegra.so");
> +        if (tegraDriverPath.exists())

check for gingerbread

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Block Flash on Tegra devices

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 620847 [details] [diff] [review]
Block Flash on Tegra devices

[Approval Request Comment]
Trivial patch, fixes very noticeable bug on a relatively popular set of devices. Mobile only.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/086e419f370a

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/609e87ff8279

Comment 11

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 15.0a1 (2012-05-22)
                  Aurora 14.0a2 (2012-05-22)

Tegra device: LG Optimus 2X (2.2.2)