Last Comment Bug 777923 - untargeted link clicks in the social notification panels sould open in a new tab
: untargeted link clicks in the social notification panels sould open in a new tab
Status: RESOLVED FIXED
[fx16]
:
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 17
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 14:15 PDT by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2012-07-28 18:37 PDT (History)
1 user (show)
gavin.sharp: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.34 KB, patch)
2012-07-26 14:20 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
mixedpuppy: review+
Details | Diff | Review

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-26 14:15:26 PDT
Same as bug 775336, but for the notification popups.
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-26 14:20:24 PDT
Created attachment 646337 [details] [diff] [review]
patch
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-26 14:26:22 PDT
Comment on attachment 646337 [details] [diff] [review]
patch

This doesn't seem to work.
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-27 11:34:44 PDT
Comment on attachment 646337 [details] [diff] [review]
patch

So this doesn't solve all of the potential problems, but we should do it anyways.
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-27 11:55:19 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7c25e3f685
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:37:25 PDT
https://hg.mozilla.org/mozilla-central/rev/ce7c25e3f685

Note You need to log in before you can comment on or make changes to this bug.