Closed
Bug 778086
Opened 12 years ago
Closed 7 years ago
Reimplement ChromeObjectWrapper with getPrototype proxy hook
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
INACTIVE
People
(Reporter: bholley, Unassigned)
References
Details
Attachments
(1 file)
|
13.16 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Split off from bug 760109 comment 40.
Once we have a getPrototype hook in proxies, we can kill the annoying double-lookup that we do in ChromeObjectWrapper, and ChromeObjectWrapper can just be a CrossCompartmentWrapper with an added getPrototype hook.
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 648710 [details] [diff] [review]
Kill ChromeObjectWrapper. v1
The dependent bug landed, so now we can land this!
Blake, this should be super-easy to review - it's basically just backing out all the hand-rolled machinery from bug 760109 now that the JS engine does this stuff for us. Tests still pass of course.
Attachment #648710 -
Flags: review?(mrbkap)
|
||
Updated•12 years ago
|
Attachment #648710 -
Flags: review?(mrbkap) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=7cfa52e1c11f
|
||
Comment 4•7 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•