NS_IMPL_STRING_ATTR incorrectly uses bool as nsresult

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Looks like this is due to bug 742549.  NS_IMPL_STRING_ATTR previously called GetAttrHelper, which called GetAttr, ignored the value, and always returned NS_OK.  Bug 742549 changed it to return the result of GetAttr, which is a bool, not nsresult.
Er, oops.  SetAttr and GetAttr have different return types...

The GetAttr case should just always return NS_OK.  Want to patch and I'll review?
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Created attachment 647115 [details] [diff] [review]
Patch
Attachment #647115 - Flags: review?(bzbarsky)
Try: https://tbpl.mozilla.org/?tree=Try&rev=35a0ff8e7053
Comment on attachment 647115 [details] [diff] [review]
Patch

r=me
Attachment #647115 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac1975f6837b
Flags: in-testsuite-
Target Milestone: --- → mozilla17

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ac1975f6837b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.