778104 - NS_IMPL_STRING_ATTR incorrectly uses bool as nsresult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Looks like this is due to bug 742549.  NS_IMPL_STRING_ATTR previously called GetAttrHelper, which called GetAttr, ignored the value, and always returned NS_OK.  Bug 742549 changed it to return the result of GetAttr, which is a bool, not nsresult.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Er, oops.  SetAttr and GetAttr have different return types...

The GetAttr case should just always return NS_OK.  Want to patch and I'll review?

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=35a0ff8e7053

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 647115 [details] [diff] [review]
Patch

r=me

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac1975f6837b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ac1975f6837b