Closed Bug 778104 Opened 7 years ago Closed 7 years ago
_IMPL _STRING _ATTR incorrectly uses bool as nsresult
Looks like this is due to bug 742549. NS_IMPL_STRING_ATTR previously called GetAttrHelper, which called GetAttr, ignored the value, and always returned NS_OK. Bug 742549 changed it to return the result of GetAttr, which is a bool, not nsresult.
Er, oops. SetAttr and GetAttr have different return types... The GetAttr case should just always return NS_OK. Want to patch and I'll review?
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Comment on attachment 647115 [details] [diff] [review] Patch r=me
Attachment #647115 - Flags: review?(bzbarsky) → review+
Target Milestone: --- → mozilla17
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.