The default bug view has changed. See this FAQ.

remove the limit on number of actions in the filter editor

RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Filters
--
minor
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 1 bug, {polish})

Trunk
Thunderbird 17.0
polish
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.76 KB, patch
neil@parkwaycc.co.uk
: review+
rkent
: feedback+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
The filter editor currently only allows to define a fixed number of actions. The number depends on the server type and equals the number of items visible in the dropdown menu where the actions are chosen from. E.g. it is 14 for POP3 and 11 for News.

In bug 541416 (and already before it) we allowed some actions to occur an unlimited number of times in a single filter. So being consistent, there should not be any arbitrary limit on the total number of actions. I have not seen bugs/reports of people hitting this hidden limit, but removing it seems like the right thing to do for correctness.
(Assignee)

Comment 1

5 years ago
Created attachment 646746 [details] [diff] [review]
patch
Attachment #646746 - Flags: review?(kent)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Keywords: polish
(Assignee)

Updated

5 years ago
Attachment #646746 - Flags: review?(neil)

Comment 2

5 years ago
Comment on attachment 646746 [details] [diff] [review]
patch

Seems reasonable.
Attachment #646746 - Flags: review?(neil) → review+
Aceman why didn't you set the checking needed keyword on this one ?
(Assignee)

Comment 4

5 years ago
Comment on attachment 646746 [details] [diff] [review]
patch

I didn't want to land this without agreement from rkent.
I'll try to set a request type that he is more likely to accept ;)
Attachment #646746 - Flags: review?(kent) → feedback?(kent)

Comment 5

5 years ago
Comment on attachment 646746 [details] [diff] [review]
patch

This also seems fine to me.
Attachment #646746 - Flags: feedback?(kent) → feedback+
(Assignee)

Comment 6

5 years ago
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2a0df861b5eb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
(Assignee)

Updated

4 years ago
Blocks: 862739
You need to log in before you can comment on or make changes to this bug.