Closed Bug 778324 Opened 8 years ago Closed 8 years ago

remove the limit on number of actions in the filter editor

Categories

(MailNews Core :: Filters, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: aceman, Assigned: aceman)

References

(Blocks 1 open bug)

Details

(Keywords: polish)

Attachments

(1 file)

The filter editor currently only allows to define a fixed number of actions. The number depends on the server type and equals the number of items visible in the dropdown menu where the actions are chosen from. E.g. it is 14 for POP3 and 11 for News.

In bug 541416 (and already before it) we allowed some actions to occur an unlimited number of times in a single filter. So being consistent, there should not be any arbitrary limit on the total number of actions. I have not seen bugs/reports of people hitting this hidden limit, but removing it seems like the right thing to do for correctness.
Attached patch patchSplinter Review
Attachment #646746 - Flags: review?(kent)
Status: NEW → ASSIGNED
Keywords: polish
Attachment #646746 - Flags: review?(neil)
Comment on attachment 646746 [details] [diff] [review]
patch

Seems reasonable.
Attachment #646746 - Flags: review?(neil) → review+
Aceman why didn't you set the checking needed keyword on this one ?
Comment on attachment 646746 [details] [diff] [review]
patch

I didn't want to land this without agreement from rkent.
I'll try to set a request type that he is more likely to accept ;)
Attachment #646746 - Flags: review?(kent) → feedback?(kent)
Comment on attachment 646746 [details] [diff] [review]
patch

This also seems fine to me.
Attachment #646746 - Flags: feedback?(kent) → feedback+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2a0df861b5eb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Blocks: 862739
You need to log in before you can comment on or make changes to this bug.