Closed
Bug 778324
Opened 12 years ago
Closed 12 years ago
remove the limit on number of actions in the filter editor
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: aceman, Assigned: aceman)
References
(Blocks 1 open bug)
Details
(Keywords: polish)
Attachments
(1 file)
|
2.76 KB,
patch
|
neil
:
review+
rkent
:
feedback+
|
Details | Diff | Splinter Review |
The filter editor currently only allows to define a fixed number of actions. The number depends on the server type and equals the number of items visible in the dropdown menu where the actions are chosen from. E.g. it is 14 for POP3 and 11 for News.
In bug 541416 (and already before it) we allowed some actions to occur an unlimited number of times in a single filter. So being consistent, there should not be any arbitrary limit on the total number of actions. I have not seen bugs/reports of people hitting this hidden limit, but removing it seems like the right thing to do for correctness.
Attachment #646746 -
Flags: review?(kent)
Attachment #646746 -
Flags: review?(neil)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 646746 [details] [diff] [review]
patch
Seems reasonable.
Attachment #646746 -
Flags: review?(neil) → review+
|
||
Comment 3•12 years ago
|
||
Aceman why didn't you set the checking needed keyword on this one ?
Comment on attachment 646746 [details] [diff] [review]
patch
I didn't want to land this without agreement from rkent.
I'll try to set a request type that he is more likely to accept ;)
Attachment #646746 -
Flags: review?(kent) → feedback?(kent)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 646746 [details] [diff] [review]
patch
This also seems fine to me.
Attachment #646746 -
Flags: feedback?(kent) → feedback+
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in
before you can comment on or make changes to this bug.
Description
•