778340 - Tab tray button action should be fired on mousedown instead of command

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jonathan Wilde [:jwilde]]

Good suggestion from Jared:

Since there's a delay time between mousedown and mouseup and, compared to mouse, it's a little trickier on touch to cancel the tap action (you have to drag your finger along the screen and off of the button), it might make sense to have the toolbar buttons fire on mousedown instead of mouseup, so that the specified action can begin while the user is moving their finger off of the screen.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for filing the bug Jonathan.

I notice about a 100-200ms delay between coming into contact with the screen and the action beginning, since currently it only begins when I remove my finger from the screen.

I would only expect experienced pianists to have very quick finger tapping skillz, so moving towards a mousedown activation of UI elements for Metro should get us a pretty good perceived-performance win.

Comment 2

[Frank Yan (:fryn)]

I disagree. I think the error rate would be extremely high, as each time a user swipes a button (trying to hide a toolbar or something), the toolbar button action would be executed. I think the right solution is to have zero actions that require double-tapping buttons, so we can immediately calculate whether it was a tap or swipe and execute the action on finger release, instead of having to wait several hundred milliseconds to see if a second tap occurs. It's sad that some apps have brought back double-tapping (the touch equivalent of double-clicking), including Instagram.

The piano analogy is not valid, I think, because pressing keys on a keyboard intentionally initiates the sound, and the duration of the hold changes the resulting sound.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The specific button that this was about is the "+" button for showing the tabs. This button doesn't have a double-tap action associated with it, but it feels slow since there is an animation associated with showing the tabs.

Comment 4

[Frank Yan (:fryn)]

Ah, for that specific button, since swipe and tap should perform the same action, this seems like a good, clever optimization. :)

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Jonathan, can you test this out on Metro for me?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Oops, this should be better :)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

Maybe the third time is a charm?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/elm/rev/f273002e4501

Comment 9

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.