Ensure dist/bin/metro/chrome is created if it doesn't exist in browser/extensions/Makefile.in

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: jwilde, Assigned: jwilde)

Tracking

Trunk
x86
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: completed-elm)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 646790 [details] [diff] [review]
quick fix

I'm currently having an issue (possibly related to threading?) where $(DIST)/bin/metro/chrome isn't around by the time line 40 of browser/extensions/Makefile.in gets run.  The attached patch fixes the build for me, but I doubt it's the most elegant way to go about things.
Seems like a safe fix, extensions is listed as a PARALLEL_DIRS directory. Not sure what order that gets executed in relation to DIRS, which is how the metro sub dir is referenced. I would suggest seeking feedback from gavin.

If you land this on elm but not mc, this bug should block bug 747347 so that it gets migrated with the rest of the non-metro specific code bits.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

7 years ago
Assignee: nobody → jonathan
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Summary: Fix directory creation issue in browser/extensions/Makefile.in → Ensure dist/bin/metro/chrome is created if it doesn't exist in browser/extensions/Makefile.in
(Assignee)

Updated

7 years ago
Blocks: 747347
Nice, thanks for catching that and fixing it.

Updated

6 years ago
Component: General → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.