778381 - Ensure dist/bin/metro/chrome is created if it doesn't exist in browser/extensions/Makefile.in

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jonathan Wilde [:jwilde]]

Attachment: quick fix

I'm currently having an issue (possibly related to threading?) where $(DIST)/bin/metro/chrome isn't around by the time line 40 of browser/extensions/Makefile.in gets run.  The attached patch fixes the build for me, but I doubt it's the most elegant way to go about things.

Comment 1

[Jim Mathies [:jimm]]

Seems like a safe fix, extensions is listed as a PARALLEL_DIRS directory. Not sure what order that gets executed in relation to DIRS, which is how the metro sub dir is referenced. I would suggest seeking feedback from gavin.

If you land this on elm but not mc, this bug should block bug 747347 so that it gets migrated with the rest of the non-metro specific code bits.

Comment 2

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/projects/elm/rev/8a55cb759145

Comment 3

[Brian R. Bondy [:bbondy]]

Nice, thanks for catching that and fixing it.

Comment 4

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.