778503 - Enable simple-prefs.js in all applications

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[backy0175]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713134347

Steps to reproduce:

I would like to develop extension for Thunderbird.



Actual results:

But simple-prefs.js disabled in Thunderbird.

	// XXX Currently, only Firefox implements the inline preferences.
	if (!require("xul-app").is("Firefox"))
	  throw Error("This API is only supported in Firefox");


Expected results:

In my quick hack,
Enable simple-prefs.js by comment out these lines and install extension with modified simple-prefs.js.
It seems working well in Thunderbird.

So I am hoping enable spmple-prefs.js in Thunderbird officially.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

The module should work in Thunderbird without modification, you are right, I'll run the tests there later and find out.

Comment 2

[backy0175]

(In reply to Erik Vold [:erikvold] from comment #1)
> The module should work in Thunderbird without modification, you are right,

I'm grad to hear it.

I noticed other modules has same restriction, as follows.

Add-on SDK 1.8.1
  context-menu.js:if (!require("api-utils/xul-app").is("Firefox")) {
  page-mod.js:// This bug is fixed in Firefox 4.0.1, but we want to keep FF 4.0 compatibility
  panel.js:if (!require("api-utils/xul-app").is("Firefox")) {
  private-browsing.js:if (require("api-utils/xul-app").is("Firefox")) {
  selection.js:if (!require("api-utils/xul-app").is("Firefox")) {
  simple-prefs.js:if (!require("xul-app").is("Firefox"))
  tabs.js:if (!require("api-utils/xul-app").is("Firefox")) {
  widget.js:if (!require("api-utils/xul-app").is("Firefox")) {
  windows.js:if (!require("api-utils/xul-app").is("Firefox")) {


Could you check these modules also?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/550

Pointer to Github pull-request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d1395f27b82cc6c1073f90d7ca4f743ed30f7951
Fix bug 778503 simple-prefs works everywhere

https://github.com/mozilla/addon-sdk/commit/71d7cfb30234cd215948bf6ff0e173285821698a
Merge pull request #550 from erikvold/778503

Fix bug 778503 simple-prefs works everywhere r=@ochameau