Closed
Bug 778560
Opened 14 years ago
Closed 14 years ago
js never uses zlib
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Benjamin, Assigned: Benjamin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
748 bytes,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Bug 776704 had a small typo:
ifdef MOZ_LIB_LIBS
DEFINES += -DUSE_ZLIB
endif
should be
ifdef MOZ_ZLIB_LIBS
DEFINES += -DUSE_ZLIB
endif
| Assignee | ||
Comment 1•14 years ago
|
||
Attachment #646986 -
Flags: review?(dmandelin)
| Assignee | ||
Comment 2•14 years ago
|
||
This version also fixes the browser build on Windows.
Assignee: general → bpeterson
Attachment #646986 -
Attachment is obsolete: true
Attachment #646986 -
Flags: review?(dmandelin)
Attachment #647077 -
Flags: review?(dmandelin)
Comment 3•14 years ago
|
||
Comment on attachment 647077 [details] [diff] [review]
fix typo
Review of attachment 647077 [details] [diff] [review]:
-----------------------------------------------------------------
Maybe add a comment on why you need to test the glue flag as well for Windows.
Attachment #647077 -
Flags: review?(dmandelin) → review+
| Assignee | ||
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•