Last Comment Bug 778560 - js never uses zlib
: js never uses zlib
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Benjamin Peterson
:
Mentors:
Depends on:
Blocks: 776704 777190
  Show dependency treegraph
 
Reported: 2012-07-29 11:00 PDT by :Benjamin Peterson
Modified: 2012-07-31 06:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix typo (723 bytes, patch)
2012-07-29 11:01 PDT, :Benjamin Peterson
no flags Details | Diff | Splinter Review
fix typo (748 bytes, patch)
2012-07-29 23:26 PDT, :Benjamin Peterson
dmandelin: review+
Details | Diff | Splinter Review

Description :Benjamin Peterson 2012-07-29 11:00:29 PDT
Bug 776704 had a small typo:
ifdef MOZ_LIB_LIBS
DEFINES += -DUSE_ZLIB
endif
should be
ifdef MOZ_ZLIB_LIBS
DEFINES += -DUSE_ZLIB
endif
Comment 1 :Benjamin Peterson 2012-07-29 11:01:59 PDT
Created attachment 646986 [details] [diff] [review]
fix typo
Comment 2 :Benjamin Peterson 2012-07-29 23:26:34 PDT
Created attachment 647077 [details] [diff] [review]
fix typo

This version also fixes the browser build on Windows.
Comment 3 David Mandelin [:dmandelin] 2012-07-30 16:42:14 PDT
Comment on attachment 647077 [details] [diff] [review]
fix typo

Review of attachment 647077 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment on why you need to test the glue flag as well for Windows.
Comment 5 Ed Morley [:emorley] 2012-07-31 06:10:59 PDT
https://hg.mozilla.org/mozilla-central/rev/c607d1fd6d35

Note You need to log in before you can comment on or make changes to this bug.