js never uses zlib

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Assigned: Benjamin)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

748 bytes, patch
dmandelin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Bug 776704 had a small typo:
ifdef MOZ_LIB_LIBS
DEFINES += -DUSE_ZLIB
endif
should be
ifdef MOZ_ZLIB_LIBS
DEFINES += -DUSE_ZLIB
endif
(Assignee)

Updated

5 years ago
Blocks: 776704
(Assignee)

Comment 1

5 years ago
Created attachment 646986 [details] [diff] [review]
fix typo
Attachment #646986 - Flags: review?(dmandelin)
(Assignee)

Comment 2

5 years ago
Created attachment 647077 [details] [diff] [review]
fix typo

This version also fixes the browser build on Windows.
Assignee: general → bpeterson
Attachment #646986 - Attachment is obsolete: true
Attachment #646986 - Flags: review?(dmandelin)
Attachment #647077 - Flags: review?(dmandelin)
(Assignee)

Updated

5 years ago
Blocks: 777190
Comment on attachment 647077 [details] [diff] [review]
fix typo

Review of attachment 647077 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment on why you need to test the glue flag as well for Windows.
Attachment #647077 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c607d1fd6d35
https://hg.mozilla.org/mozilla-central/rev/c607d1fd6d35
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.