777190 - don't compress files with huge strings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Benjamin Peterson]

Attachment: don't compress huge strings

(Moving this from bug 776200)
This implements a heuristic which detects files with large string literals. These source files are very quick to parse and compile but not very fast to compress. Thus, we just abort compression for files with these characteristics.

Comment 1

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a338900cf0af

Comment 2

[:Benjamin Peterson]

Wrong bug.

Comment 3

[:Benjamin Peterson]

Attachment: don't compress huge strings

A few tweaks.

Comment 4

[:Benjamin Peterson]

Attachment: don't compress huge strings

More tweaking.

Comment 5

[:Benjamin Peterson]

Attachment: don't compress huge strings

Rebased.

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 647290 [details] [diff] [review]
don't compress huge strings

I can't find a thing wrong with this.

Comment 7

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3ddad2296ad

Comment 8

[Ed Morley [:emorley]]

Looks like this improved numbers somewhat :-D

https://groups.google.com/d/topic/mozilla.dev.tree-management/xqs-0zhynig/discussion
https://groups.google.com/d/topic/mozilla.dev.tree-management/I8Go7NJN-8c/discussion

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c3ddad2296ad