Last Comment Bug 777190 - don't compress files with huge strings
: don't compress files with huge strings
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal with 1 vote (vote)
: mozilla17
Assigned To: :Benjamin Peterson
:
Mentors:
Depends on: 778560 779372 780965 804897
Blocks: savesource 776741
  Show dependency treegraph
 
Reported: 2012-07-24 18:07 PDT by :Benjamin Peterson
Modified: 2012-10-23 21:00 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
don't compress huge strings (16.79 KB, patch)
2012-07-24 18:07 PDT, :Benjamin Peterson
no flags Details | Diff | Splinter Review
don't compress huge strings (18.98 KB, patch)
2012-07-24 21:10 PDT, :Benjamin Peterson
no flags Details | Diff | Splinter Review
don't compress huge strings (19.95 KB, patch)
2012-07-25 09:46 PDT, :Benjamin Peterson
no flags Details | Diff | Splinter Review
don't compress huge strings (19.98 KB, patch)
2012-07-30 14:02 PDT, :Benjamin Peterson
jorendorff: review+
Details | Diff | Splinter Review

Description :Benjamin Peterson 2012-07-24 18:07:10 PDT
Created attachment 645609 [details] [diff] [review]
don't compress huge strings

(Moving this from bug 776200)
This implements a heuristic which detects files with large string literals. These source files are very quick to parse and compile but not very fast to compress. Thus, we just abort compression for files with these characteristics.
Comment 2 :Benjamin Peterson 2012-07-24 19:04:04 PDT
Wrong bug.
Comment 3 :Benjamin Peterson 2012-07-24 21:10:04 PDT
Created attachment 645643 [details] [diff] [review]
don't compress huge strings

A few tweaks.
Comment 4 :Benjamin Peterson 2012-07-25 09:46:05 PDT
Created attachment 645797 [details] [diff] [review]
don't compress huge strings

More tweaking.
Comment 5 :Benjamin Peterson 2012-07-30 14:02:00 PDT
Created attachment 647290 [details] [diff] [review]
don't compress huge strings

Rebased.
Comment 6 Jason Orendorff [:jorendorff] 2012-07-30 16:50:20 PDT
Comment on attachment 647290 [details] [diff] [review]
don't compress huge strings

I can't find a thing wrong with this.
Comment 9 Ed Morley [:emorley] 2012-07-31 06:10:52 PDT
https://hg.mozilla.org/mozilla-central/rev/c3ddad2296ad

Note You need to log in before you can comment on or make changes to this bug.