don't compress files with huge strings

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Assigned: Benjamin)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 645609 [details] [diff] [review]
don't compress huge strings

(Moving this from bug 776200)
This implements a heuristic which detects files with large string literals. These source files are very quick to parse and compile but not very fast to compress. Thus, we just abort compression for files with these characteristics.
Attachment #645609 - Flags: review?(jorendorff)
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a338900cf0af
(Assignee)

Comment 2

5 years ago
Wrong bug.
(Assignee)

Comment 3

5 years ago
Created attachment 645643 [details] [diff] [review]
don't compress huge strings

A few tweaks.
Assignee: general → bpeterson
Attachment #645643 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Attachment #645609 - Attachment is obsolete: true
Attachment #645609 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Blocks: 776741
Whiteboard: [js:t]
(Assignee)

Comment 4

5 years ago
Created attachment 645797 [details] [diff] [review]
don't compress huge strings

More tweaking.
Attachment #645643 - Attachment is obsolete: true
Attachment #645643 - Flags: review?(jorendorff)
Attachment #645797 - Flags: review?(jorendorff)
(Assignee)

Comment 5

5 years ago
Created attachment 647290 [details] [diff] [review]
don't compress huge strings

Rebased.
Attachment #645797 - Attachment is obsolete: true
Attachment #645797 - Flags: review?(jorendorff)
Attachment #647290 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Depends on: 778560
Comment on attachment 647290 [details] [diff] [review]
don't compress huge strings

I can't find a thing wrong with this.
Attachment #647290 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3ddad2296ad

Comment 8

5 years ago
Looks like this improved numbers somewhat :-D

https://groups.google.com/d/topic/mozilla.dev.tree-management/xqs-0zhynig/discussion
https://groups.google.com/d/topic/mozilla.dev.tree-management/I8Go7NJN-8c/discussion

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c3ddad2296ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Blocks: 761723
Depends on: 779372
Depends on: 780965

Updated

5 years ago
Depends on: 804897
You need to log in before you can comment on or make changes to this bug.