Middleware code + unit tests cleanup

RESOLVED FIXED in 25

Status

RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: adrian, Assigned: adrian)

Tracking

unspecified

Details

(Whiteboard: [qa-])

(Assignee)

Description

7 years ago
There are a few improvements that can be done pretty quickly to the middleware code, first adding the "postgres" attribute to all integration tests, second making check.py happy again. 

Also, there is a few code redundancy that can be removed.
(Assignee)

Comment 1

6 years ago
As this will come after the new middleware using configman is released, I'll also make a change to use Lars' connection_context class to query Postgresql.
(Assignee)

Updated

6 years ago
Target Milestone: 19 → 20
(Assignee)

Updated

6 years ago
Target Milestone: 20 → 21
(Assignee)

Updated

6 years ago
Blocks: 787233
(Assignee)

Comment 2

6 years ago
This work is waiting for Peter's "configmanization" of the middleware, see https://github.com/mozilla/socorro/pull/811 for status.
(Assignee)

Updated

6 years ago
Target Milestone: 21 → 22
(Assignee)

Updated

6 years ago
Target Milestone: 22 → Future

Comment 3

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b52378808dc8d67489d0e99002322d795a3b943b
Fixes bug 778744 - Cleaned up middleware and its unit tests.

https://github.com/mozilla/socorro/commit/aab27dfd3bd24e503b84b85e9c0af7c7763a78ab
bug 778744 - pep 8 cleanup

https://github.com/mozilla/socorro/commit/2f26ffeaef89d4dcdeb6cf657151cbfb8366db81
Merge pull request #1 from Lonnen/778744-pep8

bug 778744 - pep 8 cleanup

https://github.com/mozilla/socorro/commit/b0ddb7534cadb8c2aa432cf21e1370e8542a48ea
Merge pull request #884 from AdrianGaudebert/778744-cleanup-middleware-and-tests

Fixes bug 778744 - Cleaned up middleware and its unit tests.

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: Future → 24
(Assignee)

Updated

6 years ago
Whiteboard: [qa-]

Comment 4

6 years ago
This didn't actually make the cut for 24, and is in 25 instead.
Target Milestone: 24 → 25
Product: Socorro → Socorro Graveyard
You need to log in before you can comment on or make changes to this bug.