778858 - Web runtime does not use OOP plugins outside of Windows Vista/7

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[John Schoenick [:johns]]

webrt seems to run plugins in-process by default on windows XP, which is undesirable.

Possible explanation:
https://bugzilla.mozilla.org/show_bug.cgi?id=771090#c5

webrt uses OOP on windows vista+ due to:
https://hg.mozilla.org/mozilla-central/rev/b39f4007be5a

Comment 1

[John Schoenick [:johns]]

Attachment: Enable OOP plugins in webapprt by default

Comment 2

[John Schoenick [:johns]]

Comment on attachment 647605 [details] [diff] [review]
Enable OOP plugins in webapprt by default

dom.ipc.plugins.enabled lives in firefox.js and not all.js or webapprt/prefs.js - right now then, we only use OOP plugins on Windows Vista+ where they are forced, never on XP/OS X/Linux.

This adds the necessary prefs to webapprt/prefs.js, though an alternative would be migrating the prefs to all.js

Myk - are you the right person to review this?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I think we should really push to move this to all.js, but that's a bigger task. Can you at least make sure we have a bug on file?

Comment 4

[John Schoenick [:johns]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> I think we should really push to move this to all.js, but that's a bigger
> task. Can you at least make sure we have a bug on file?

I filed bug 779240 for this

Comment 5

[Jason Smith [:jsmith]]

We might want to double-check that patch. I just patched mozilla central and built firefox with that patch, and I'm crashing every single time I try access plugin content in a web app.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 647605 [details] [diff] [review]
Enable OOP plugins in webapprt by default

I tested the patch on Mac OS X (64bit), Windows 7 (64bit), and Windows XP (32bit), and they all behaved as expected, loading Flash in a separate process and not crashing.

Comment 7

[John Schoenick [:johns]]

Comment on attachment 647605 [details] [diff] [review]
Enable OOP plugins in webapprt by default

http://hg.mozilla.org/integration/mozilla-inbound/rev/d0d82983f678

Comment 8

[John Schoenick [:johns]]

(In reply to Jason Smith [:jsmith] from comment #5)
> We might want to double-check that patch. I just patched mozilla central and
> built firefox with that patch, and I'm crashing every single time I try
> access plugin content in a web app.

I couldn't reproduce this either - OOP seems to work fine in linux, and the flash apps I tried work. Does your build for this include the fix for bug 771090?

Comment 9

[Jason Smith [:jsmith]]

(In reply to John Schoenick [:johns] from comment #8)
> (In reply to Jason Smith [:jsmith] from comment #5)
> > We might want to double-check that patch. I just patched mozilla central and
> > built firefox with that patch, and I'm crashing every single time I try
> > access plugin content in a web app.
> 
> I couldn't reproduce this either - OOP seems to work fine in linux, and the
> flash apps I tried work. Does your build for this include the fix for bug
> 771090?

I think so, but this is probably a problem on my end (I just recently started doing direct builds of Firefox with patches, so I probably screwed something up on my end).

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d0d82983f678