778863 - [socorro-crashstats] URL table on report/list hard to copy because of cut-off lines

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

The URL tab in report/list is nice, but often we have to (potentially sanitize and) copy the list to a bug report to give developers information to find reproducible cases.
When doing that via simple copy & paste, the cut-off long URLs also get transferred to the bug as being cut off, which is unhelpful.

We should find some solution to copy the list without having those being cut off like that.

Comment 1

[Schalk Neethling [:espressive]]

I have an idea for this, will revisit after mobeta.

Comment 3

[Schalk Neethling [:espressive]]

How weird, I was actually looking for this one the other day. Will make it part of the work done on the rewrite.

Comment 4

[Schalk Neethling [:espressive]]

(In reply to Robert Kaiser (:[e-mail]) from comment #0)
> The URL tab in report/list is nice, but often we have to (potentially
> sanitize and) copy the list to a bug report to give developers information
> to find reproducible cases.
> When doing that via simple copy & paste, the cut-off long URLs also get
> transferred to the bug as being cut off, which is unhelpful.
> 
> We should find some solution to copy the list without having those being cut
> off like that.

Hey KaiRo,

So, I am guessing you would not always copy all of the URLs but, might want to select only a subset based on need, correct?

Comment 5

[Robert Kaiser]

Yes, usually I copy and paste the top URLs up until a certain amount of hits, then edit the pasted variant to exclude adult content (in some cases it's obvious, in some not and I might even need to visit them), then I'm - right now due to this bug - copying over the full URLs to replace the cut-off ones, and then I'm looking for passwords, user or session IDs to possibly redact.

Comment 6

[Schalk Neethling [:espressive]]

(In reply to Robert Kaiser (:[e-mail]) from comment #5)
> Yes, usually I copy and paste the top URLs up until a certain amount of
> hits, then edit the pasted variant to exclude adult content (in some cases
> it's obvious, in some not and I might even need to visit them), then I'm -
> right now due to this bug - copying over the full URLs to replace the
> cut-off ones, and then I'm looking for passwords, user or session IDs to
> possibly redact.

Ok, so with this I am thinking of adding two triggers at the top and bottom of the list, one to expand all and contract all. The first allowing you to copy the full unedited URL when you want to copy and the second, again lessening the clutter down to the 85 character current limit.

Does this sound like something that will work for you? Also, with that, which would you prefer to be the default, expanded or collapsed?

Comment 7

[Robert Kaiser]

That sounds like a good solution to me, and I think we can leave collapsed as the default for reasons of screen estate.

Comment 8

[Robert Helmer [:rhelmer]]

This is a feature request, not a regression from the PHP app right? Not sure why I set it blocking... 

Schalk if you get this done in time I think we should take it since it seems low-risk, but I think we could ship without it.

Comment 9

[Schalk Neethling [:espressive]]

Test Case
---------

1) Log into crash-stats using browser id.
2) Once successfully logged in, navigate to the report/list page and click on the URLs tab.
3) Once the tab contents has loaded, you will find a button with the label 'Show Full URLs'
4) Locate a URL in the list of URLs that is truncated (it will end with ...)
5 )When you click on the above mentioned button, the truncated URLs should expand into the full URL.
6) Also, note that the text of the button should change to 'Truncate URLs'

7) You should also test the inverse of this i.e. clicking truncate and confirm that the URLs are truncated again and that the button text changes back to 'Show Full URLs'

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8e9663c4147eb4bd204418901c693f346bd69d0f
Fix Bug 778863, provide functionality to expand and truncate urls to make copying easier

https://github.com/mozilla/socorro/commit/8e9ba6290aaabb8ec499bf79a978890112ccc801
Merge pull request #1628 from ossreleasefeed/bug778863-make-urls-easier-to-copy

Fix Bug 778863, provide functionality to expand and truncate urls to make copying easier

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa_verified.png

QA verified on stage - looks great; thanks for the excellent str. 

https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-11-05&signature=mozilla%3A%3Adom%3A%3AWindowBinding%3A%3Aget_content&version=Firefox%3A28.0a1

Once logged in the urls tab correctly displays; the newly added Show Full URLS/Truncate URLS button correctly updates the urls throughout the page. The button also updates with the correct text that reflects the page's state.