779024 - live functional tests differ with/without M2Crypto

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

Using PyBrowserID 0.7 without M2Crypto, AITC functional tests receive a "401" error from the tokenserver.

With M2Crypto installed, the same tests get a "503" error from the tokenserver.

Tested on both prod and stage.  Probably a PyBrowserID bug.

Comment 1

[Alexis Metaireau (:alexis)]

Do you have any traceback for this?

Comment 2

[Ryan Kelly [:rfkelly]]

(In reply to Alexis Metaireau (:alexis) from comment #1)
> Do you have any traceback for this?

No traceback, since nothing was failing - the RSA signatures generated by pure-python PyBrowserID were just wrong, and were being rejected by the code running M2Crypto on the server.

Bugfix for PyBrowserID is here:

  https://github.com/mozilla/PyBrowserID/pull/14

Comment 3

[Ryan Kelly [:rfkelly]]

PyBrowserID 0.8 has been released to fix this issue, and the relevant deps files have been updated.  Pulling and rebuilding server-aitc should make the functional tests pass without installing M2Crypto.

Comment 4

[Alexis Metaireau (:alexis)]

Is it also true for the tokenserver, or should I release a new version of it with the new PyBrowserID dependency?

Comment 5

[Ryan Kelly [:rfkelly]]

Ah, good point, I did not touch tokenserver.  Since it builds M2Crypto as a hard dependency it should not have been affected by this bug, so I don't think we need to rush out a new deployment.  Worth updating in trunk though.

Comment 6

[James Bonacci [:jbonacci]]

Verified in local installs. Assume good in larger deploys.