Florian: Why do we only call _addConversation in the chat tab openTab function when conversationsGroup is next to searchResultConv? http://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#107 -Mike
(In reply to Mike Conley (:mconley) from comment #1) > Florian: > > Why do we only call _addConversation in the chat tab openTab function when > conversationsGroup is next to searchResultConv? > > http://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat- > messenger-overlay.js#107 > > -Mike That code (lines 108-116) builds the displayed list of conversations the first time the chat tab is opened. "conversationsGroup is next to searchResultConv" is a way to test that the list of displayed conversations is currently empty. After that, new conversations are added when the new-ui-conversation notification is received. The bug here is because when receiving new-ui-conversation we test gChatTab as a way to know if the chat tab is opened, but we should instead test if it has ever been opened, or something like that.
Created attachment 647997 [details] [diff] [review] Patch v1 Something like this?
Attachment #647997 - Flags: review?(florian)
Comment on attachment 647997 [details] [diff] [review] Patch v1 This patch is ok with me if it fixes the issue (I'm assuming again that you have verified it does ;)).
Attachment #647997 - Flags: review?(florian) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
tracking-thunderbird15: --- → ?
tracking-thunderbird16: --- → ?
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
tracking-thunderbird15: ? → +
tracking-thunderbird16: ? → +
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/60d11d425271 comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/a4b3e0cbff5d
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
You need to log in before you can comment on or make changes to this bug.