779321 - Switching to synced tabs in the tab bar causes the current page to animate (10" tablet)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

1) Open Firefox (for tablet)
2) Click the tab bar (with the # icon).
3) Clicked the synced tab icon

Expected: The synced tab bar replaces the currently open tab bar
Actual: The above, though the current page slides to the right

Closing the synced tab bar causes the same animation.

This was tested on the Asus Transformer Prime, 4.0.3.

I could not test on FF Beta as it crashes when I try to sync.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 652480 [details] [diff] [review]
Patch

Review of attachment 652480 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/ca2c1aa1acbc

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/ca2c1aa1acbc

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 652480 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): tablet UI changes
User impact if declined: prevents a visual glitch
Testing completed (on m-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch: none

I don't think we should take the risk for beta, but getting this cleaned up on aurora before uplift would be good.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 652480 [details] [diff] [review]
Patch

mobile only, we can take this on Aurora and watch for any regressions - also can QA verify?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/98c1284b9429