Last Comment Bug 779372 - Compile error on Windows js shells involving zlib
: Compile error on Windows js shells involving zlib
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All Windows 7
: -- blocker (vote)
: mozilla17
Assigned To: :Benjamin Peterson
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 777190
  Show dependency treegraph
Reported: 2012-07-31 17:49 PDT by Gary Kwong [:gkw] [:nth10sd]
Modified: 2012-08-07 19:27 PDT (History)
2 users (show)
gary: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

stdout (28.89 KB, text/plain)
2012-07-31 17:49 PDT, Gary Kwong [:gkw] [:nth10sd]
no flags Details
add missing #ifdef (588 bytes, patch)
2012-07-31 19:50 PDT, :Benjamin Peterson
jorendorff: review+
Details | Diff | Splinter Review

Description Gary Kwong [:gkw] [:nth10sd] 2012-07-31 17:49:57 PDT
Created attachment 647794 [details]

There is a compile error on Windows js shells involving zlib, see attached log.
Comment 1 Gary Kwong [:gkw] [:nth10sd] 2012-07-31 18:53:17 PDT
This suggested patch by Benjamin over IRC does not work:

diff -r 162b401d8774 js/src/jsutil.h
--- a/js/src/jsutil.h   Tue Jul 31 17:35:46 2012 -0700
+++ b/js/src/jsutil.h   Tue Jul 31 17:43:50 2012 -0700
@@ -10,17 +10,19 @@
 #ifndef jsutil_h___
 #define jsutil_h___
 #include "mozilla/Attributes.h"
 #include "js/Utility.h"
+#ifdef USE_ZLIB
 #include "zlib.h"
 /* Forward declarations. */
 struct JSContext;
 static JS_ALWAYS_INLINE void *
 js_memcpy(void *dst_, const void *src_, size_t len)
     char *dst = (char *) dst_;
Comment 2 Gary Kwong [:gkw] [:nth10sd] 2012-07-31 18:56:18 PDT
I was using pymake on mozilla-central changeset 02346e2e7156.
Comment 3 Gary Kwong [:gkw] [:nth10sd] 2012-07-31 19:21:57 PDT
I used (with MozillaBuild and Visual Studio 2010):

--disable-optimize --enable-debug --enable-methodjit --enable-type-inference --enable-more-deterministic --disable-tests

The patch in bug 779393 does not fix this.
Comment 4 Gary Kwong [:gkw] [:nth10sd] 2012-07-31 19:45:43 PDT
(In reply to Gary Kwong [:gkw, :nth10sd] from comment #1)
> This suggested patch by Benjamin over IRC does not work:

On further checking, the patch in comment 1 (in conjunction with the patch in bug 779393) does make it work. Something else in my harness is making it fail but that's out of the scope of this bug.
Comment 5 :Benjamin Peterson 2012-07-31 19:50:02 PDT
Created attachment 647829 [details] [diff] [review]
add missing #ifdef
Comment 6 Gary Kwong [:gkw] [:nth10sd] 2012-08-01 10:02:42 PDT
This should land as soon as possible once mozilla-inbound is reopened.
Comment 8 Gary Kwong [:gkw] [:nth10sd] 2012-08-01 11:27:15 PDT
in-testsuite- because this fixes a compile error.
Comment 9 Gary Kwong [:gkw] [:nth10sd] 2012-08-01 17:25:37 PDT
This was likely caused by bug 777190.
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-08-01 19:41:50 PDT

Note You need to log in before you can comment on or make changes to this bug.