Last Comment Bug 779378 - B2G Voicemail: Hook up to permissions manager
: B2G Voicemail: Hook up to permissions manager
Status: RESOLVED FIXED
[LOE:S]
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Kyle Machulis [:kmachulis] [:qdot]
:
Mentors:
Depends on:
Blocks: 774716 764618
  Show dependency treegraph
 
Reported: 2012-07-31 18:17 PDT by Marshall Culpepper [:marshall_law]
Modified: 2012-08-24 20:05 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager (1.73 KB, patch)
2012-08-20 15:42 PDT, Kyle Machulis [:kmachulis] [:qdot]
anygregor: review-
Details | Diff | Review
Patch 1 (v2) - B2G Voicemail: Hook up to permissions manager (3.57 KB, patch)
2012-08-22 11:20 PDT, Kyle Machulis [:kmachulis] [:qdot]
no flags Details | Diff | Review
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager (3.57 KB, patch)
2012-08-22 11:43 PDT, Kyle Machulis [:kmachulis] [:qdot]
anygregor: review+
Details | Diff | Review

Description Marshall Culpepper [:marshall_law] 2012-07-31 18:17:31 PDT
Need to remove the whitelist pref, and properly hook up to PermissionManager API
Comment 1 Kyle Machulis [:kmachulis] [:qdot] 2012-08-20 15:42:45 PDT
Created attachment 653558 [details] [diff] [review]
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager

Getting this out of the way so I can land bug 764618. 

PS YOU'RE WELCOME, MARSHALL
Comment 2 Gregor Wagner [:gwagner] 2012-08-20 18:40:55 PDT
Comment on attachment 653558 [details] [diff] [review]
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager

Review of attachment 653558 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to fix the marionette tests. For example:
https://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_voicemail_statuschanged.js#4
Comment 3 Marshall Culpepper [:marshall_law] 2012-08-21 07:33:30 PDT
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #1)
> PS YOU'RE WELCOME, MARSHALL

<3

FYI the code you need to change for the voicemail test can be seen in the mobile newtork tests
- here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#7
- and here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#234
Comment 4 Kyle Machulis [:kmachulis] [:qdot] 2012-08-22 11:20:28 PDT
Created attachment 654283 [details] [diff] [review]
Patch 1 (v2) - B2G Voicemail: Hook up to permissions manager

Now with marionette changes!
Comment 5 Kyle Machulis [:kmachulis] [:qdot] 2012-08-22 11:43:24 PDT
Created attachment 654296 [details] [diff] [review]
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager
Comment 6 Marshall Culpepper [:marshall_law] 2012-08-23 08:01:11 PDT
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #5)
> Created attachment 654296 [details] [diff] [review]
> Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Ran both tests with this patch locally, and they passed :)
Comment 7 Gregor Wagner [:gwagner] 2012-08-23 11:28:25 PDT
Comment on attachment 654296 [details] [diff] [review]
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Thanks!
Comment 8 Kyle Machulis [:kmachulis] [:qdot] 2012-08-23 16:31:20 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb991da28af
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-08-24 20:05:50 PDT
https://hg.mozilla.org/mozilla-central/rev/8eb991da28af

Note You need to log in before you can comment on or make changes to this bug.