Closed Bug 779378 Opened 11 years ago Closed 11 years ago

B2G Voicemail: Hook up to permissions manager

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17
Project Flags:
blocking-basecamp +

People

(Reporter: marshall, Assigned: qdot)

References

Details

(Whiteboard: [LOE:S])

Attachments

(1 file, 2 obsolete files)

Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager
3.57 KB, patch
gwagner
: review+
Details | Diff | Splinter Review 
Need to remove the whitelist pref, and properly hook up to PermissionManager API
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
Whiteboard: [LOE:S]
Getting this out of the way so I can land bug 764618. 

PS YOU'RE WELCOME, MARSHALL
Assignee: marshall → kyle
Attachment #653558 - Flags: review?(anygregor)
Comment on attachment 653558 [details] [diff] [review]
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager

Review of attachment 653558 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to fix the marionette tests. For example:
https://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_voicemail_statuschanged.js#4
Attachment #653558 - Flags: review?(anygregor) → review-
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #1)
> PS YOU'RE WELCOME, MARSHALL

<3

FYI the code you need to change for the voicemail test can be seen in the mobile newtork tests
- here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#7
- and here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#234
Now with marionette changes!
Attachment #653558 - Attachment is obsolete: true
Attachment #654283 - Flags: review?(anygregor)

        Attachment #654283 -
        Attachment is obsolete: true

        Attachment #654283 -
        Flags: review?(anygregor)

        Attachment #654296 -
        Flags: review?(anygregor)

    
    

    
  
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #5)
> Created attachment 654296 [details] [diff] [review]
> Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Ran both tests with this patch locally, and they passed :)

    
    

    
  
Comment on attachment 654296 [details] [diff] [review]
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Thanks!

        Attachment #654296 -
        Flags: review?(anygregor) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8eb991da28af
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

          You need to log in
          before you can comment on or make changes to this bug.