The default bug view has changed. See this FAQ.

B2G Voicemail: Hook up to permissions manager

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: marshall_law, Assigned: qdot)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: [LOE:S])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Need to remove the whitelist pref, and properly hook up to PermissionManager API
blocking-basecamp: --- → ?
(Assignee)

Updated

5 years ago
Blocks: 764618
blocking-basecamp: ? → +
(Reporter)

Updated

5 years ago
Whiteboard: [LOE:S]
(Assignee)

Comment 1

5 years ago
Created attachment 653558 [details] [diff] [review]
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager

Getting this out of the way so I can land bug 764618. 

PS YOU'RE WELCOME, MARSHALL
Assignee: marshall → kyle
Attachment #653558 - Flags: review?(anygregor)
Comment on attachment 653558 [details] [diff] [review]
Patch 1 (v1): B2G Voicemail: Hook up to permissions manager

Review of attachment 653558 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to fix the marionette tests. For example:
https://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_voicemail_statuschanged.js#4
Attachment #653558 - Flags: review?(anygregor) → review-
(Reporter)

Comment 3

5 years ago
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #1)
> PS YOU'RE WELCOME, MARSHALL

<3

FYI the code you need to change for the voicemail test can be seen in the mobile newtork tests
- here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#7
- and here: https://mxr.mozilla.org/mozilla-central/source/dom/network/tests/marionette/test_mobile_networks.js#234
(Assignee)

Comment 4

5 years ago
Created attachment 654283 [details] [diff] [review]
Patch 1 (v2) - B2G Voicemail: Hook up to permissions manager

Now with marionette changes!
Attachment #653558 - Attachment is obsolete: true
Attachment #654283 - Flags: review?(anygregor)
(Assignee)

Comment 5

5 years ago
Created attachment 654296 [details] [diff] [review]
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager
Attachment #654283 - Attachment is obsolete: true
Attachment #654283 - Flags: review?(anygregor)
Attachment #654296 - Flags: review?(anygregor)
(Reporter)

Comment 6

5 years ago
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #5)
> Created attachment 654296 [details] [diff] [review]
> Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Ran both tests with this patch locally, and they passed :)
Comment on attachment 654296 [details] [diff] [review]
Patch 1 (v3) - B2G Voicemail: Hook up to permissions manager

Thanks!
Attachment #654296 - Flags: review?(anygregor) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb991da28af
https://hg.mozilla.org/mozilla-central/rev/8eb991da28af
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.