774716 - [meta] Unify PermissionManager usage

Status: RESOLVED INCOMPLETE

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Currently we are using several patterns to test permissions (whitelist-check, permission-database, no checks).
We should unify the checks to only go into the permissionDB via the permissionManager.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Basically this is the bug to change up the various security-check hacks that we have to making callers use nsIPermissionManager?

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Jonas Sicking (:sicking) from comment #1)
> Basically this is the bug to change up the various security-check hacks that
> we have to making callers use nsIPermissionManager?

Yes I want to change everything to nsIPermissionManager. I don't think I can do this with a single bug because it touches every single API so I will make this bug a meta bug and handle each API individually with its own bug.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> (In reply to Jonas Sicking (:sicking) from comment #1)
> > Basically this is the bug to change up the various security-check hacks that
> > we have to making callers use nsIPermissionManager?
> 
> Yes I want to change everything to nsIPermissionManager. I don't think I can
> do this with a single bug because it touches every single API so I will make
> this bug a meta bug and handle each API individually with its own bug.

You could also attach various patches to this bug, one for each API. It might be simpler to manage.

Comment 4

[Gregor Wagner [:gwagner]]

(In reply to Mounir Lamouri (:mounir) from comment #3)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > (In reply to Jonas Sicking (:sicking) from comment #1)
> > > Basically this is the bug to change up the various security-check hacks that
> > > we have to making callers use nsIPermissionManager?
> > 
> > Yes I want to change everything to nsIPermissionManager. I don't think I can
> > do this with a single bug because it touches every single API so I will make
> > this bug a meta bug and handle each API individually with its own bug.
> 
> You could also attach various patches to this bug, one for each API. It
> might be simpler to manage.

Alright. I just created one for the Contacts API. But I will post all others in here.

Comment 5

[Lucas Adamski [:ladamski]]

Is this a meta bug?

Comment 6

[Philipp von Weitershausen [:philikon]]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> > You could also attach various patches to this bug, one for each API. It
> > might be simpler to manage.
> 
> Alright. I just created one for the Contacts API. But I will post all others
> in here.

I added some dependencies for the bugs we already had on file. At this point this bug might be considered a tracking bug or close to that.

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

More mass-incompleting of FxOS bugs in the Device Interfaces component.

Please update and let me know if any of these are still valid.