[meta] Unify PermissionManager usage

RESOLVED INCOMPLETE

Status

()

defect
RESOLVED INCOMPLETE
7 years ago
a year ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

(Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

7 years ago
Currently we are using several patterns to test permissions (whitelist-check, permission-database, no checks).
We should unify the checks to only go into the permissionDB via the permissionManager.
Basically this is the bug to change up the various security-check hacks that we have to making callers use nsIPermissionManager?
(Assignee)

Comment 2

7 years ago
(In reply to Jonas Sicking (:sicking) from comment #1)
> Basically this is the bug to change up the various security-check hacks that
> we have to making callers use nsIPermissionManager?

Yes I want to change everything to nsIPermissionManager. I don't think I can do this with a single bug because it touches every single API so I will make this bug a meta bug and handle each API individually with its own bug.
(Assignee)

Updated

7 years ago
Depends on: 775199
(In reply to Gregor Wagner [:gwagner] from comment #2)
> (In reply to Jonas Sicking (:sicking) from comment #1)
> > Basically this is the bug to change up the various security-check hacks that
> > we have to making callers use nsIPermissionManager?
> 
> Yes I want to change everything to nsIPermissionManager. I don't think I can
> do this with a single bug because it touches every single API so I will make
> this bug a meta bug and handle each API individually with its own bug.

You could also attach various patches to this bug, one for each API. It might be simpler to manage.
(Assignee)

Comment 4

7 years ago
(In reply to Mounir Lamouri (:mounir) from comment #3)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > (In reply to Jonas Sicking (:sicking) from comment #1)
> > > Basically this is the bug to change up the various security-check hacks that
> > > we have to making callers use nsIPermissionManager?
> > 
> > Yes I want to change everything to nsIPermissionManager. I don't think I can
> > do this with a single bug because it touches every single API so I will make
> > this bug a meta bug and handle each API individually with its own bug.
> 
> You could also attach various patches to this bug, one for each API. It
> might be simpler to manage.

Alright. I just created one for the Contacts API. But I will post all others in here.
blocking-basecamp: --- → ?
(Assignee)

Updated

7 years ago
Assignee: nobody → anygregor
Is this a meta bug?
(In reply to Gregor Wagner [:gwagner] from comment #4)
> > You could also attach various patches to this bug, one for each API. It
> > might be simpler to manage.
> 
> Alright. I just created one for the Contacts API. But I will post all others
> in here.

I added some dependencies for the bugs we already had on file. At this point this bug might be considered a tracking bug or close to that.
blocking-basecamp: ? → ---
Keywords: meta
Summary: Unify PermissionManager usage → [meta] Unify PermissionManager usage
(Assignee)

Updated

7 years ago
Depends on: 776764
blocking-basecamp: --- → ?
blocking-basecamp: ? → ---
(Assignee)

Updated

7 years ago
Depends on: 779331
(Assignee)

Updated

7 years ago
Depends on: 779353
Depends on: 779498
No longer depends on: 778384
(Assignee)

Updated

7 years ago
Depends on: 781297
(Assignee)

Updated

7 years ago
Depends on: 781331
(Assignee)

Updated

7 years ago
Depends on: 781353
(Assignee)

Updated

7 years ago
Depends on: 781355
No longer blocks: basecamp-security

Updated

7 years ago
Depends on: 783500
Depends on: 783511

Updated

7 years ago
Depends on: 783151

Updated

7 years ago
Depends on: 783573
Depends on: 764131
(Assignee)

Updated

7 years ago
Depends on: 794331
More mass-incompleting of FxOS bugs in the Device Interfaces component.

Please update and let me know if any of these are still valid.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.