Closed Bug 779384 Opened 9 years ago Closed 9 years ago

B2G Bluetooth: Hook up to permissions manager

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17
blocking-basecamp +

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(1 file)

Remove the URI based permissions check and move to using the PermissionsManager for checks. 

https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#6834
blocking-basecamp: --- → ?
Comment on attachment 649882 [details] [diff] [review]
Patch 1: Hook bluetooth up to permissions manager

Review of attachment 649882 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothManager.cpp
@@ +278,5 @@
> +    aWindow->GetCurrentInnerWindow();
> +
> +  // Need the document for security check.
> +  nsCOMPtr<nsIDocument> document =
> +    do_QueryInterface(innerWindow->GetExtantDocument());

You can avoid a do_QueryInterface by using innerWindow->GetExtantDoc() instead here.
Attachment #649882 - Flags: review?(mrbkap) → review+
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/8f7045786fbf
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.