779384 - B2G Bluetooth: Hook up to permissions manager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Remove the URI based permissions check and move to using the PermissionsManager for checks. 

https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#6834

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1: Hook bluetooth up to permissions manager

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 649882 [details] [diff] [review]
Patch 1: Hook bluetooth up to permissions manager

Review of attachment 649882 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothManager.cpp
@@ +278,5 @@
> +    aWindow->GetCurrentInnerWindow();
> +
> +  // Need the document for security check.
> +  nsCOMPtr<nsIDocument> document =
> +    do_QueryInterface(innerWindow->GetExtantDocument());

You can avoid a do_QueryInterface by using innerWindow->GetExtantDoc() instead here.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f7045786fbf

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8f7045786fbf