Closed
Bug 779384
Opened 12 years ago
Closed 12 years ago
B2G Bluetooth: Hook up to permissions manager
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: qdot, Assigned: qdot)
References
Details
Attachments
(1 file)
|
2.33 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Remove the URI based permissions check and move to using the PermissionsManager for checks.
https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#6834
|
Assignee | |
Updated•12 years ago
|
blocking-basecamp: --- → ?
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #649882 -
Flags: review?(mrbkap)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 649882 [details] [diff] [review]
Patch 1: Hook bluetooth up to permissions manager
Review of attachment 649882 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bluetooth/BluetoothManager.cpp
@@ +278,5 @@
> + aWindow->GetCurrentInnerWindow();
> +
> + // Need the document for security check.
> + nsCOMPtr<nsIDocument> document =
> + do_QueryInterface(innerWindow->GetExtantDocument());
You can avoid a do_QueryInterface by using innerWindow->GetExtantDoc() instead here.
Attachment #649882 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Target Milestone: --- → mozilla17
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•