B2G Bluetooth: Hook up to permissions manager

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

Remove the URI based permissions check and move to using the PermissionsManager for checks. 

https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#6834
blocking-basecamp: --- → ?
Created attachment 649882 [details] [diff] [review]
Patch 1: Hook bluetooth up to permissions manager
Attachment #649882 - Flags: review?(mrbkap)
Blocks: 764618
Comment on attachment 649882 [details] [diff] [review]
Patch 1: Hook bluetooth up to permissions manager

Review of attachment 649882 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothManager.cpp
@@ +278,5 @@
> +    aWindow->GetCurrentInnerWindow();
> +
> +  // Need the document for security check.
> +  nsCOMPtr<nsIDocument> document =
> +    do_QueryInterface(innerWindow->GetExtantDocument());

You can avoid a do_QueryInterface by using innerWindow->GetExtantDoc() instead here.
Attachment #649882 - Flags: review?(mrbkap) → review+
Blocks: 774716
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f7045786fbf
Target Milestone: --- → mozilla17
blocking-basecamp: ? → +

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8f7045786fbf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.