Closed Bug 779448 Opened 9 years ago Closed 9 years ago

Add contentDescription to the "go" image button (the right-pointing arrow)

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(firefox17 verified, firefox18 verified)

VERIFIED FIXED
Firefox 17
Tracking Status
firefox17 --- verified
firefox18 --- verified

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

The buttons is missing the contentDescription for accessibility, so swiping to the right in Jelly Bean will find an unlabeled button.
Attached patch Patch (obsolete) — Splinter Review
Started a try-run here: https://tbpl.mozilla.org/?tree=Try&rev=c98e089e0303
Attachment #647928 - Flags: review?(sriram)
Comment on attachment 647928 [details] [diff] [review]
Patch

Review of attachment 647928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. How would this change for "search" more when the button changes to search icon?
Attachment #647928 - Flags: review?(sriram) → review+
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Looks good to me. How would this change for "search" more when the button
> changes to search icon?

Oh, so this changes icons? I obviously missed that fact since I can't see the screen. Then this approach won't work, and I'll have to add/change the contentDescription in code for this one. I'll submit a new patch later.
This patch updates the contentDescription whenever the button gets updated, alongside the image in use.

Accompanying try run: https://tbpl.mozilla.org/?tree=Try&rev=3c672f748ac4
Attachment #647928 - Attachment is obsolete: true
Attachment #648285 - Flags: review?(sriram)
Attachment #648285 - Flags: review?(sriram) → review+
https://hg.mozilla.org/mozilla-central/rev/35451c7292ba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified on:
Nightly 18.0a1 (2012-09-20)
Aurora 17.0a2 (2012-09-20)
Galaxy Nexus (Android 4.1.1)

Both the Search and Go buttons are proper display and function as expected
Status: RESOLVED → VERIFIED
Blocks: 900011
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.