779448 - Add contentDescription to the "go" image button (the right-pointing arrow)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Marco Zehe (:MarcoZ)]

The buttons is missing the contentDescription for accessibility, so swiping to the right in Jelly Bean will find an unlabeled button.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

Started a try-run here: https://tbpl.mozilla.org/?tree=Try&rev=c98e089e0303

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 647928 [details] [diff] [review]
Patch

Review of attachment 647928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. How would this change for "search" more when the button changes to search icon?

Comment 3

[Marco Zehe (:MarcoZ)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Looks good to me. How would this change for "search" more when the button
> changes to search icon?

Oh, so this changes icons? I obviously missed that fact since I can't see the screen. Then this approach won't work, and I'll have to add/change the contentDescription in code for this one. I'll submit a new patch later.

Comment 4

[Marco Zehe (:MarcoZ)]

Attachment: Patch2, handles dynamic changing of the button

This patch updates the contentDescription whenever the button gets updated, alongside the image in use.

Accompanying try run: https://tbpl.mozilla.org/?tree=Try&rev=3c672f748ac4

Comment 5

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/35451c7292ba

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35451c7292ba

Comment 7

[Paul Feher]

Verified on:
Nightly 18.0a1 (2012-09-20)
Aurora 17.0a2 (2012-09-20)
Galaxy Nexus (Android 4.1.1)

Both the Search and Go buttons are proper display and function as expected