Closed
Bug 779448
Opened 12 years ago
Closed 12 years ago
Add contentDescription to the "go" image button (the right-pointing arrow)
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox17 verified, firefox18 verified)
VERIFIED
FIXED
Firefox 17
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
1.94 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
The buttons is missing the contentDescription for accessibility, so swiping to the right in Jelly Bean will find an unlabeled button.
Assignee | ||
Comment 1•12 years ago
|
||
Started a try-run here: https://tbpl.mozilla.org/?tree=Try&rev=c98e089e0303
Attachment #647928 -
Flags: review?(sriram)
Comment 2•12 years ago
|
||
Comment on attachment 647928 [details] [diff] [review] Patch Review of attachment 647928 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. How would this change for "search" more when the button changes to search icon?
Attachment #647928 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #2) > Looks good to me. How would this change for "search" more when the button > changes to search icon? Oh, so this changes icons? I obviously missed that fact since I can't see the screen. Then this approach won't work, and I'll have to add/change the contentDescription in code for this one. I'll submit a new patch later.
Assignee | ||
Comment 4•12 years ago
|
||
This patch updates the contentDescription whenever the button gets updated, alongside the image in use. Accompanying try run: https://tbpl.mozilla.org/?tree=Try&rev=3c672f748ac4
Attachment #647928 -
Attachment is obsolete: true
Attachment #648285 -
Flags: review?(sriram)
Updated•12 years ago
|
Attachment #648285 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/35451c7292ba
Target Milestone: --- → Firefox 17
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/35451c7292ba
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
Verified on: Nightly 18.0a1 (2012-09-20) Aurora 17.0a2 (2012-09-20) Galaxy Nexus (Android 4.1.1) Both the Search and Go buttons are proper display and function as expected
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•