779490 - Unable to install an application with unicode characters (UTF-8) within the name

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Aaron Train [:aaronmt]]

E/GeckoConsole( 4296): [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: [Exception... "Component returned failure code: 0x8050000e (NS_ERROR_ILLEGAL_INPUT) [nsIScriptableUnicodeConverter.ConvertToUnicode]"  nsresult: "0x8050000e (NS_ERROR_ILLEGAL_INPUT)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 5895"  data: no]" {file: "resource://gre/modules/Webapps.jsm" line: 126}]

1. Go to http://ed.agadak.net/app/
2. Install Ed's app that should contain Japanese characters in the name

This is only only currently affecting mozilla-central (might be a regression from bug 766604).


{
    "name": "テスト Ed Agadak テスト",
    "launch_path": "/app",
    "default_locale": "en-US",
    "icons": {
        "32": "/favicon.ico",
        "64": "/favicon.ico"
    },
    "description": "Ed Agadak",
    "locales": {},
    "developer": {
        "url": "http://ed.agadak.net",
        "name": "Edward Lee"
    }
}

--
Nightly (08/01)
Samsung Galaxy Nexus (Android 4.1.1)

Comment 1

[Jason Smith [:jsmith]]

Hmm...bug 738298 also landed recently too, I think it's possible it might be that one too. Fabrice - Do you know?

I think it's failing in a function called "_loadJSONASync" in Webapps.jsm.

Comment 2

[[:fabrice] Fabrice Desré]

Yep, that's bug 738298. It merged to central, can you check again?

Comment 3

[Aaron Train [:aaronmt]]

Using a tinderbox mozilla-inbound from (08/02) this still occurs.

Comment 4

[Wesley Johnston (:wesj)]

fabrice, your code is throwing on that particular manifest. Are you going to be able to look into it?

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Wesley Johnston (:wesj) from comment #4)
> fabrice, your code is throwing on that particular manifest. Are you going to
> be able to look into it?

yes

Comment 6

[Wesley Johnston (:wesj)]

Assigning this so I don't feel like I'm ignoring it then. If you are too busy fabrice, I can grab this (but I'm not sure what you're doing wrong...)

Comment 7

[Jason Smith [:jsmith]]

What's strange about this bug is that it only appears to happen on Android. Why is that the case? Is it cause Android added additional UTF-8 handling in bug 766604?

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Patch

Actually, I made us not even use this anymore and removing it fixes this.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 650397 [details] [diff] [review]
Patch

Less is better. I am tempted to have you remove the two "Got callback" logs too.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Does this need to be uplifted to Fx16?

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62f8e90be342

Hmm.. 16 is weird because the platform patch isn't there. So... no.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62f8e90be342