Closed
Bug 779665
Opened 13 years ago
Closed 13 years ago
test.py should use moztest
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: mihneadb)
References
Details
Attachments
(1 file, 1 obsolete file)
2.18 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
When you're a dog, eating dogfood is appropriate. When you're a test
harness to test the test harness, using your own test package is
appropriate.
https://github.com/mozilla/mozbase/blob/master/test.py should use the
moztest results package for outputting and processing results.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mbalaur
Assignee | ||
Comment 1•13 years ago
|
||
The patch assumes the modifications in #779664 are present, that's why I added the dependency.
Managed to keep the exit statement in one line, seems more readable this way.
Attachment #648581 -
Flags: feedback?(jhammel)
Reporter | ||
Updated•13 years ago
|
Attachment #648581 -
Flags: feedback?(jhammel) → feedback+
Assignee | ||
Comment 2•13 years ago
|
||
Also switched to *results as we discussed.
Attachment #648581 -
Attachment is obsolete: true
Attachment #649388 -
Flags: review?(jhammel)
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 649388 [details] [diff] [review]
use moztest for test results
lgtm; good next steps would be adding CLI arguments for different output formats (but not a huge priority)
Attachment #649388 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•13 years ago
|
||
Assignee | ||
Comment 7•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•