test.py should use moztest

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jeff Hammel, Assigned: mihneadb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
When you're a dog, eating dogfood is appropriate.  When you're a test
harness to test the test harness, using your own test package is
appropriate.

https://github.com/mozilla/mozbase/blob/master/test.py should use the
moztest results package for outputting and processing results.
(Assignee)

Updated

6 years ago
Assignee: nobody → mbalaur
(Assignee)

Updated

6 years ago
Depends on: 779664
(Assignee)

Comment 1

6 years ago
Created attachment 648581 [details] [diff] [review]
store results in moztest

The patch assumes the modifications in #779664 are present, that's why I added the dependency.

Managed to keep the exit statement in one line, seems more readable this way.
Attachment #648581 - Flags: feedback?(jhammel)
(Reporter)

Updated

6 years ago
Attachment #648581 - Flags: feedback?(jhammel) → feedback+
(Assignee)

Comment 2

6 years ago
Created attachment 649388 [details] [diff] [review]
use moztest for test results

Also switched to *results as we discussed.
Attachment #648581 - Attachment is obsolete: true
Attachment #649388 - Flags: review?(jhammel)
(Reporter)

Comment 3

6 years ago
Comment on attachment 649388 [details] [diff] [review]
use moztest for test results

lgtm; good next steps would be adding CLI arguments for different output formats (but not a huge priority)
Attachment #649388 - Flags: review?(jhammel) → review+
(Assignee)

Comment 4

6 years ago
https://github.com/mozilla/mozbase/commit/3b0c24ab20593c026c056e31c99c1af740b541e3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

6 years ago
test failures:
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

6 years ago
https://github.com/mozilla/mozbase/commit/5eab5f326cfadb6bfa5ed013631c90f45eee9e74
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.