Last Comment Bug 779688 - jstests.py invocation is missing $(PYTHON)
: jstests.py invocation is missing $(PYTHON)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
Mentors:
Depends on:
Blocks: 593585 735549
  Show dependency treegraph
 
Reported: 2012-08-01 16:58 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2012-08-02 06:22 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (755 bytes, patch)
2012-08-01 16:58 PDT, Siddharth Agarwal [:sid0] (inactive)
terrence.d.cole: review+
Details | Diff | Splinter Review

Description Siddharth Agarwal [:sid0] (inactive) 2012-08-01 16:58:05 PDT
Created attachment 648144 [details] [diff] [review]
patch

The jstests.py invocation needs an explicit $(PYTHON) in front. That's because (a) we'd like to run everything from a virtualenv python we don't explicitly activate, and (b) Windows.
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-08-01 16:59:14 PDT
This blocks turning on Pymake by default on Windows.
Comment 2 Terrence Cole [:terrence] 2012-08-01 17:09:40 PDT
Comment on attachment 648144 [details] [diff] [review]
patch

Review of attachment 648144 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review, since this was my mistake originally.
Comment 3 Gary Kwong [:gkw] [:nth10sd] 2012-08-01 17:22:37 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/84c7c91dd2f5
Comment 4 Ed Morley [:emorley] 2012-08-02 06:22:46 PDT
https://hg.mozilla.org/mozilla-central/rev/84c7c91dd2f5

Note You need to log in before you can comment on or make changes to this bug.